Re: [PATCH net-next v3 5/5] net: dsa: factor skb freeing on xmit

2017-06-01 Thread Florian Fainelli
On 06/01/2017 01:07 PM, Vivien Didelot wrote: > As of a86d8becc3f0 ("net: dsa: Factor bottom tag receive functions"), > the rcv caller frees the original SKB in case or error. > > Be symmetric with that and make the xmit caller do the same. > > At the same time, fix the checkpatch NULL

Re: [PATCH net-next v3 5/5] net: dsa: factor skb freeing on xmit

2017-06-01 Thread Florian Fainelli
On 06/01/2017 01:07 PM, Vivien Didelot wrote: > As of a86d8becc3f0 ("net: dsa: Factor bottom tag receive functions"), > the rcv caller frees the original SKB in case or error. > > Be symmetric with that and make the xmit caller do the same. > > At the same time, fix the checkpatch NULL

[PATCH net-next v3 5/5] net: dsa: factor skb freeing on xmit

2017-06-01 Thread Vivien Didelot
As of a86d8becc3f0 ("net: dsa: Factor bottom tag receive functions"), the rcv caller frees the original SKB in case or error. Be symmetric with that and make the xmit caller do the same. At the same time, fix the checkpatch NULL comparison check: CHECK: Comparison to NULL could be

[PATCH net-next v3 5/5] net: dsa: factor skb freeing on xmit

2017-06-01 Thread Vivien Didelot
As of a86d8becc3f0 ("net: dsa: Factor bottom tag receive functions"), the rcv caller frees the original SKB in case or error. Be symmetric with that and make the xmit caller do the same. At the same time, fix the checkpatch NULL comparison check: CHECK: Comparison to NULL could be