Re: [PATCH net-next v4 0/4] Fix OdroidC2 Gigabit Tx link issue

(quick reply...) On Fri, Jan 06, 2017 at 02:50:21PM +0100, Jerome Brunet wrote: > So I'm not sure I understand, are you against EEE integration in phylib > entirely, or specifically against the test I added in set_eee to filter > out broken modes ? I'm happy to see EEE integrated into phylib,

Re: [PATCH net-next v4 0/4] Fix OdroidC2 Gigabit Tx link issue

(quick reply...) On Fri, Jan 06, 2017 at 02:50:21PM +0100, Jerome Brunet wrote: > So I'm not sure I understand, are you against EEE integration in phylib > entirely, or specifically against the test I added in set_eee to filter > out broken modes ? I'm happy to see EEE integrated into phylib,

Re: [PATCH net-next v4 0/4] Fix OdroidC2 Gigabit Tx link issue

On Fri, 2017-01-06 at 11:42 +, Russell King - ARM Linux wrote: > On Fri, Jan 06, 2017 at 11:11:36AM +0100, Jerome Brunet wrote: > > > > The purpose of this patch is to provide a way to mark as broken a > > particular eee mode. At first, it had nothing to do with "set_eee" > > but, > > as

Re: [PATCH net-next v4 0/4] Fix OdroidC2 Gigabit Tx link issue

On Fri, 2017-01-06 at 11:42 +, Russell King - ARM Linux wrote: > On Fri, Jan 06, 2017 at 11:11:36AM +0100, Jerome Brunet wrote: > > > > The purpose of this patch is to provide a way to mark as broken a > > particular eee mode. At first, it had nothing to do with "set_eee" > > but, > > as

Re: [PATCH net-next v4 0/4] Fix OdroidC2 Gigabit Tx link issue

On Fri, Jan 06, 2017 at 06:42:24AM +0100, Yegor Yefremov wrote: > On Fri, Jan 6, 2017 at 12:25 AM, Russell King - ARM Linux > wrote: > > Another concern with this patch is that the existing phylib "set_eee" > > code is horribly buggy - it just translates the modes from

Re: [PATCH net-next v4 0/4] Fix OdroidC2 Gigabit Tx link issue

On Fri, Jan 06, 2017 at 06:42:24AM +0100, Yegor Yefremov wrote: > On Fri, Jan 6, 2017 at 12:25 AM, Russell King - ARM Linux > wrote: > > Another concern with this patch is that the existing phylib "set_eee" > > code is horribly buggy - it just translates the modes from userspace > > into the

Re: [PATCH net-next v4 0/4] Fix OdroidC2 Gigabit Tx link issue

On Fri, Jan 06, 2017 at 11:11:36AM +0100, Jerome Brunet wrote: > The purpose of this patch is to provide a way to mark as broken a > particular eee mode. At first, it had nothing to do with "set_eee" but, > as Florian rightly pointed out, users shouldn't be able to re-enable a > broken mode. I

Re: [PATCH net-next v4 0/4] Fix OdroidC2 Gigabit Tx link issue

On Fri, Jan 06, 2017 at 11:11:36AM +0100, Jerome Brunet wrote: > The purpose of this patch is to provide a way to mark as broken a > particular eee mode. At first, it had nothing to do with "set_eee" but, > as Florian rightly pointed out, users shouldn't be able to re-enable a > broken mode. I

Re: [PATCH net-next v4 0/4] Fix OdroidC2 Gigabit Tx link issue

On Thu, 2017-01-05 at 23:25 +, Russell King - ARM Linux wrote: > On Mon, Nov 28, 2016 at 09:54:28AM -0800, Florian Fainelli wrote: > > > > If we start supporting generic "enable", "disable" type of > > properties > > with values that map directly to register definitions of the HW, we > >

Re: [PATCH net-next v4 0/4] Fix OdroidC2 Gigabit Tx link issue

On Thu, 2017-01-05 at 23:25 +, Russell King - ARM Linux wrote: > On Mon, Nov 28, 2016 at 09:54:28AM -0800, Florian Fainelli wrote: > > > > If we start supporting generic "enable", "disable" type of > > properties > > with values that map directly to register definitions of the HW, we > >

Re: [PATCH net-next v4 0/4] Fix OdroidC2 Gigabit Tx link issue

Hi Russel, On Fri, Jan 6, 2017 at 12:25 AM, Russell King - ARM Linux wrote: > On Mon, Nov 28, 2016 at 09:54:28AM -0800, Florian Fainelli wrote: >> If we start supporting generic "enable", "disable" type of properties >> with values that map directly to register definitions

Re: [PATCH net-next v4 0/4] Fix OdroidC2 Gigabit Tx link issue

Hi Russel, On Fri, Jan 6, 2017 at 12:25 AM, Russell King - ARM Linux wrote: > On Mon, Nov 28, 2016 at 09:54:28AM -0800, Florian Fainelli wrote: >> If we start supporting generic "enable", "disable" type of properties >> with values that map directly to register definitions of the HW, we >> leave

Re: [PATCH net-next v4 0/4] Fix OdroidC2 Gigabit Tx link issue

On Mon, Nov 28, 2016 at 09:54:28AM -0800, Florian Fainelli wrote: > If we start supporting generic "enable", "disable" type of properties > with values that map directly to register definitions of the HW, we > leave too much room for these properties to be utilized to implement a > specific

Re: [PATCH net-next v4 0/4] Fix OdroidC2 Gigabit Tx link issue

On Mon, Nov 28, 2016 at 09:54:28AM -0800, Florian Fainelli wrote: > If we start supporting generic "enable", "disable" type of properties > with values that map directly to register definitions of the HW, we > leave too much room for these properties to be utilized to implement a > specific

Re: [PATCH net-next v4 0/4] Fix OdroidC2 Gigabit Tx link issue

On 11/30/2016 01:47 AM, Jerome Brunet wrote: >> If we start supporting generic "enable", "disable" type of properties >> with values that map directly to register definitions of the HW, we >> leave too much room for these properties to be utilized to implement >> a >> specific policy, and this is

Re: [PATCH net-next v4 0/4] Fix OdroidC2 Gigabit Tx link issue

On 11/30/2016 01:47 AM, Jerome Brunet wrote: >> If we start supporting generic "enable", "disable" type of properties >> with values that map directly to register definitions of the HW, we >> leave too much room for these properties to be utilized to implement >> a >> specific policy, and this is

Re: [PATCH net-next v4 0/4] Fix OdroidC2 Gigabit Tx link issue

On Mon, 2016-11-28 at 09:54 -0800, Florian Fainelli wrote: > On 11/28/2016 07:50 AM, Jerome Brunet wrote: > > > > This patchset fixes an issue with the OdroidC2 board (DWMAC + > > RTL8211F). > > The platform seems to enter LPI on the Rx path too often while > > performing > > relatively high TX

Re: [PATCH net-next v4 0/4] Fix OdroidC2 Gigabit Tx link issue

On Mon, 2016-11-28 at 09:54 -0800, Florian Fainelli wrote: > On 11/28/2016 07:50 AM, Jerome Brunet wrote: > > > > This patchset fixes an issue with the OdroidC2 board (DWMAC + > > RTL8211F). > > The platform seems to enter LPI on the Rx path too often while > > performing > > relatively high TX

Re: [PATCH net-next v4 0/4] Fix OdroidC2 Gigabit Tx link issue

On 11/28/2016 07:50 AM, Jerome Brunet wrote: > This patchset fixes an issue with the OdroidC2 board (DWMAC + RTL8211F). > The platform seems to enter LPI on the Rx path too often while performing > relatively high TX transfer. This eventually break the link (both Tx and > Rx), and require to bring

Re: [PATCH net-next v4 0/4] Fix OdroidC2 Gigabit Tx link issue

On 11/28/2016 07:50 AM, Jerome Brunet wrote: > This patchset fixes an issue with the OdroidC2 board (DWMAC + RTL8211F). > The platform seems to enter LPI on the Rx path too often while performing > relatively high TX transfer. This eventually break the link (both Tx and > Rx), and require to bring

[PATCH net-next v4 0/4] Fix OdroidC2 Gigabit Tx link issue

This patchset fixes an issue with the OdroidC2 board (DWMAC + RTL8211F). The platform seems to enter LPI on the Rx path too often while performing relatively high TX transfer. This eventually break the link (both Tx and Rx), and require to bring the interface down and up again to get the Rx path

[PATCH net-next v4 0/4] Fix OdroidC2 Gigabit Tx link issue

This patchset fixes an issue with the OdroidC2 board (DWMAC + RTL8211F). The platform seems to enter LPI on the Rx path too often while performing relatively high TX transfer. This eventually break the link (both Tx and Rx), and require to bring the interface down and up again to get the Rx path