Re: [PATCH net-next v4 1/2] lib: vsprintf: add IPv4/v6 generic %p[Ii]S[pfs] format specifier

2013-06-28 Thread Joe Perches
On Fri, 2013-06-28 at 19:49 +0200, Daniel Borkmann wrote: > In order to avoid making code that deals with printing both, IPv4 and > IPv6 addresses, unnecessary complicated as for example ... Looks good to me. Thanks Daniel for keeping at it. -- To unsubscribe from this list: send the line

[PATCH net-next v4 1/2] lib: vsprintf: add IPv4/v6 generic %p[Ii]S[pfs] format specifier

2013-06-28 Thread Daniel Borkmann
In order to avoid making code that deals with printing both, IPv4 and IPv6 addresses, unnecessary complicated as for example ... if (sa.sa_family == AF_INET6) printk("... %pI6 ...", ..sin6_addr); else printk("... %pI4 ...", ..sin_addr.s_addr); ... it would be better to introduce a

[PATCH net-next v4 1/2] lib: vsprintf: add IPv4/v6 generic %p[Ii]S[pfs] format specifier

2013-06-28 Thread Daniel Borkmann
In order to avoid making code that deals with printing both, IPv4 and IPv6 addresses, unnecessary complicated as for example ... if (sa.sa_family == AF_INET6) printk(... %pI6 ..., ..sin6_addr); else printk(... %pI4 ..., ..sin_addr.s_addr); ... it would be better to introduce a format

Re: [PATCH net-next v4 1/2] lib: vsprintf: add IPv4/v6 generic %p[Ii]S[pfs] format specifier

2013-06-28 Thread Joe Perches
On Fri, 2013-06-28 at 19:49 +0200, Daniel Borkmann wrote: In order to avoid making code that deals with printing both, IPv4 and IPv6 addresses, unnecessary complicated as for example ... Looks good to me. Thanks Daniel for keeping at it. -- To unsubscribe from this list: send the line