Re: [PATCH net-next v4 5/5] net: hdlc_fr: Add support for any Ethertype

2020-10-30 Thread Willem de Bruijn
On Fri, Oct 30, 2020 at 3:29 PM Xie He wrote: > > On Fri, Oct 30, 2020 at 9:33 AM Willem de Bruijn > wrote: > > > > Should this still check data[5] == FR_PAD? > > No, the 6th byte (data[5]) is not a padding field. It is the first > byte of the SNAP header. The original code is misleading. That

Re: [PATCH net-next v4 5/5] net: hdlc_fr: Add support for any Ethertype

2020-10-30 Thread Xie He
On Fri, Oct 30, 2020 at 9:33 AM Willem de Bruijn wrote: > > Should this still check data[5] == FR_PAD? No, the 6th byte (data[5]) is not a padding field. It is the first byte of the SNAP header. The original code is misleading. That is part of the reasons why I want to fix it with this patch.

Re: [PATCH net-next v4 5/5] net: hdlc_fr: Add support for any Ethertype

2020-10-30 Thread Willem de Bruijn
On Thu, Oct 29, 2020 at 10:32 PM Xie He wrote: > > Change the fr_rx function to make this driver support any Ethertype > when receiving skbs on normal (non-Ethernet-emulating) PVC devices. > (This driver is already able to handle any Ethertype when sending.) > > Originally in the fr_rx function,

[PATCH net-next v4 5/5] net: hdlc_fr: Add support for any Ethertype

2020-10-29 Thread Xie He
Change the fr_rx function to make this driver support any Ethertype when receiving skbs on normal (non-Ethernet-emulating) PVC devices. (This driver is already able to handle any Ethertype when sending.) Originally in the fr_rx function, the code that parses the long (10-byte) header only