From: Rafal Ozieblo
Date: Tue, 15 Nov 2016 07:07:14 +
> Would it be good to enable UFO conditionally with some internal
> define? Ex.:
Absolutely not.
> From: Eric Dumazet [mailto:eric.duma...@gmail.com]
> Sent: 15 listopada 2016 14:12
> To: Rafal Ozieblo
> Cc: David Miller; nicolas.fe...@atmel.com; net...@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH net-next v5] cadence: Add LSO support.
>
>
On Tue, 2016-11-15 at 07:07 +, Rafal Ozieblo wrote:
> > > > If UFO is in use it should not silently disable UDP checksums.
> > > >
> > > > If you cannot support UFO with proper checksumming, then you cannot
> > > > enable support for that feature.
> > >
> > > According Cadence Gigabit Ethern
> > > If UFO is in use it should not silently disable UDP checksums.
> > >
> > > If you cannot support UFO with proper checksumming, then you cannot
> > > enable support for that feature.
> >
> > According Cadence Gigabit Ethernet MAC documentation:
> >
> > "Hardware will not calculate the UDP
From: Rafal Ozieblo
Date: Mon, 14 Nov 2016 09:32:34 +
>> If UFO is in use it should not silently disable UDP checksums.
>>
>> If you cannot support UFO with proper checksumming, then you cannot enable
>> support for that feature.
>
> According Cadence Gigabit Ethernet MAC documentation:
>
On Mon, 2016-11-14 at 09:32 +, Rafal Ozieblo wrote:
> From: David Miller [mailto:da...@davemloft.net]
> Sent: 10 listopada 2016 18:01
> To: Rafal Ozieblo
> Cc: nicolas.fe...@atmel.com; net...@vger.kernel.org;
> linux-kernel@vger.kernel.org
> Subject: Re: [PATCH net-next v5]
From: David Miller [mailto:da...@davemloft.net]
Sent: 10 listopada 2016 18:01
To: Rafal Ozieblo
Cc: nicolas.fe...@atmel.com; net...@vger.kernel.org;
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v5]] cadence: Add LSO support.
From: Rafal Ozieblo
Date: Wed, 9 Nov 2016 13:41:02 +
From: Rafal Ozieblo
Date: Wed, 9 Nov 2016 13:41:02 +
First, please remove the spurious closing bracket in your Subject line
in future submittions.
> + if (is_udp) /* is_udp is only set when (is_lso) is checked */
> + /* zero UDP checksum, not calculated by h/w for UFO */
> +
New Cadence GEM hardware support Large Segment Offload (LSO):
TCP segmentation offload (TSO) as well as UDP fragmentation
offload (UFO). Support for those features was added to the driver.
Signed-off-by: Rafal Ozieblo
---
Changed in v2:
macb_lso_check_compatibility() changed to macb_features_chec
9 matches
Mail list logo
