Re: [PATCH net-next v5 05/22] ethtool: introduce ethtool netlink interface

2019-03-26 Thread Michal Kubecek
On Tue, Mar 26, 2019 at 05:36:40PM +0100, Jiri Pirko wrote: > Mon, Mar 25, 2019 at 06:08:09PM CET, mkube...@suse.cz wrote: > >+/* genetlink setup */ > >+ > >+static const struct genl_ops ethtool_genl_ops[] = { > > Please be consistent with prefixes. Either use "ethtool_" or "ethnl_" > for all

Re: [PATCH net-next v5 05/22] ethtool: introduce ethtool netlink interface

2019-03-26 Thread Michal Kubecek
On Tue, Mar 26, 2019 at 01:09:09PM +0100, Jiri Pirko wrote: > Mon, Mar 25, 2019 at 06:08:09PM CET, mkube...@suse.cz wrote: > >+All "set" and "action" type requests require admin privileges (CAP_NET_ADMIN > >+in the namespace). Most "get" type request are allowed for anyone but there > >