Re: [PATCH net-next v5 1/9] xen-netback: Introduce TX grant map definitions

2014-02-24 Thread Ian Campbell
On Fri, 2014-02-21 at 01:19 +, Zoltan Kiss wrote: > I don't know if the guest expects that slots for the same packet > comes back at the same time. I don't think the guest is allowed to assume that. In particular they aren't allowed to assume the the slots will be freed in the order they wer

Re: [PATCH net-next v5 1/9] xen-netback: Introduce TX grant map definitions

2014-02-20 Thread Zoltan Kiss
On 20/02/14 09:33, Ian Campbell wrote: On Wed, 2014-02-19 at 19:54 +, Zoltan Kiss wrote: On 19/02/14 10:05, Ian Campbell wrote: On Tue, 2014-02-18 at 20:36 +, Zoltan Kiss wrote: On 18/02/14 17:06, Ian Campbell wrote: On Mon, 2014-01-20 at 21:24 +, Zoltan Kiss wrote: This patch co

Re: [PATCH net-next v5 1/9] xen-netback: Introduce TX grant map definitions

2014-02-20 Thread Wei Liu
On Wed, Feb 19, 2014 at 07:54:29PM +, Zoltan Kiss wrote: > On 19/02/14 10:05, Ian Campbell wrote: > >On Tue, 2014-02-18 at 20:36 +, Zoltan Kiss wrote: > >>On 18/02/14 17:06, Ian Campbell wrote: > >>>On Mon, 2014-01-20 at 21:24 +, Zoltan Kiss wrote: > This patch contains the new defi

Re: [PATCH net-next v5 1/9] xen-netback: Introduce TX grant map definitions

2014-02-20 Thread Ian Campbell
On Wed, 2014-02-19 at 19:54 +, Zoltan Kiss wrote: > On 19/02/14 10:05, Ian Campbell wrote: > > On Tue, 2014-02-18 at 20:36 +, Zoltan Kiss wrote: > >> On 18/02/14 17:06, Ian Campbell wrote: > >>> On Mon, 2014-01-20 at 21:24 +, Zoltan Kiss wrote: > This patch contains the new definit

Re: [PATCH net-next v5 1/9] xen-netback: Introduce TX grant map definitions

2014-02-19 Thread Zoltan Kiss
On 19/02/14 10:05, Ian Campbell wrote: On Tue, 2014-02-18 at 20:36 +, Zoltan Kiss wrote: On 18/02/14 17:06, Ian Campbell wrote: On Mon, 2014-01-20 at 21:24 +, Zoltan Kiss wrote: This patch contains the new definitions necessary for grant mapping. Is this just adding a bunch of (curre

Re: [PATCH net-next v5 1/9] xen-netback: Introduce TX grant map definitions

2014-02-19 Thread Zoltan Kiss
On 18/02/14 17:24, Ian Campbell wrote: On Mon, 2014-01-20 at 21:24 +, Zoltan Kiss wrote: + spinlock_t dealloc_lock; + spinlock_t response_lock; Please add comments to both of these describing what bits of the datastructure they are locking. You might find it is clearer to gro

Re: [PATCH net-next v5 1/9] xen-netback: Introduce TX grant map definitions

2014-02-19 Thread Ian Campbell
On Tue, 2014-02-18 at 20:36 +, Zoltan Kiss wrote: > On 18/02/14 17:06, Ian Campbell wrote: > > On Mon, 2014-01-20 at 21:24 +, Zoltan Kiss wrote: > >> This patch contains the new definitions necessary for grant mapping. > > > > Is this just adding a bunch of (currently) unused functions? Tha

Re: [PATCH net-next v5 1/9] xen-netback: Introduce TX grant map definitions

2014-02-18 Thread Zoltan Kiss
On 18/02/14 17:06, Ian Campbell wrote: On Mon, 2014-01-20 at 21:24 +, Zoltan Kiss wrote: This patch contains the new definitions necessary for grant mapping. Is this just adding a bunch of (currently) unused functions? That's a slightly odd way to structure a series. They don't seem to be

Re: [PATCH net-next v5 1/9] xen-netback: Introduce TX grant map definitions

2014-02-18 Thread Ian Campbell
On Mon, 2014-01-20 at 21:24 +, Zoltan Kiss wrote: > > + spinlock_t dealloc_lock; > + spinlock_t response_lock; Please add comments to both of these describing what bits of the datastructure they are locking. You might find it is clearer to group the locks and the things they pro

Re: [PATCH net-next v5 1/9] xen-netback: Introduce TX grant map definitions

2014-02-18 Thread Ian Campbell
On Mon, 2014-01-20 at 21:24 +, Zoltan Kiss wrote: > This patch contains the new definitions necessary for grant mapping. Is this just adding a bunch of (currently) unused functions? That's a slightly odd way to structure a series. They don't seem to be "generic helpers" or anything so it would

[PATCH net-next v5 1/9] xen-netback: Introduce TX grant map definitions

2014-01-20 Thread Zoltan Kiss
This patch contains the new definitions necessary for grant mapping. v2: - move unmapping to separate thread. The NAPI instance has to be scheduled even from thread context, which can cause huge delays - that causes unfortunately bigger struct xenvif - store grant handle after checking validity