Re: [PATCH net-next v6 3/3] selftests: drv-net: Test queue xsk attribute

2025-02-12 Thread Joe Damato
On Tue, Feb 11, 2025 at 06:37:06PM -0800, Jakub Kicinski wrote: > On Tue, 11 Feb 2025 15:10:52 -0800 Stanislav Fomichev wrote: > > > I can't comment on NIPA because I have no idea how it works. Maybe > > > there is a kernel with some options enabled and other kernels with > > > various options disa

Re: [PATCH net-next v6 3/3] selftests: drv-net: Test queue xsk attribute

2025-02-11 Thread Jakub Kicinski
On Tue, 11 Feb 2025 15:10:52 -0800 Stanislav Fomichev wrote: > > I can't comment on NIPA because I have no idea how it works. Maybe > > there is a kernel with some options enabled and other kernels with > > various options disabled? > > Sorry, should've been more clear. My suggestion is to add

Re: [PATCH net-next v6 3/3] selftests: drv-net: Test queue xsk attribute

2025-02-11 Thread Stanislav Fomichev
On 02/11, Joe Damato wrote: > On Tue, Feb 11, 2025 at 12:00:38PM -0800, Stanislav Fomichev wrote: > > On 02/11, Joe Damato wrote: > > > On Tue, Feb 11, 2025 at 09:45:56AM -0800, Joe Damato wrote: > > > > On Tue, Feb 11, 2025 at 12:09:50PM +0100, Paolo Abeni wrote: > > > > > On 2/10/25 8:38 PM, Joe

Re: [PATCH net-next v6 3/3] selftests: drv-net: Test queue xsk attribute

2025-02-11 Thread Joe Damato
On Tue, Feb 11, 2025 at 12:00:38PM -0800, Stanislav Fomichev wrote: > On 02/11, Joe Damato wrote: > > On Tue, Feb 11, 2025 at 09:45:56AM -0800, Joe Damato wrote: > > > On Tue, Feb 11, 2025 at 12:09:50PM +0100, Paolo Abeni wrote: > > > > On 2/10/25 8:38 PM, Joe Damato wrote: [...] > > > > > > > >

Re: [PATCH net-next v6 3/3] selftests: drv-net: Test queue xsk attribute

2025-02-11 Thread Stanislav Fomichev
On 02/11, Joe Damato wrote: > On Tue, Feb 11, 2025 at 09:45:56AM -0800, Joe Damato wrote: > > On Tue, Feb 11, 2025 at 12:09:50PM +0100, Paolo Abeni wrote: > > > On 2/10/25 8:38 PM, Joe Damato wrote: > > > > +def check_xdp(cfg, nl, xdp_queue_id=0) -> None: > > > > +test_dir = os.path.dirname(os.

Re: [PATCH net-next v6 3/3] selftests: drv-net: Test queue xsk attribute

2025-02-11 Thread Joe Damato
On Tue, Feb 11, 2025 at 09:45:56AM -0800, Joe Damato wrote: > On Tue, Feb 11, 2025 at 12:09:50PM +0100, Paolo Abeni wrote: > > On 2/10/25 8:38 PM, Joe Damato wrote: > > > +def check_xdp(cfg, nl, xdp_queue_id=0) -> None: > > > +test_dir = os.path.dirname(os.path.realpath(__file__)) > > > +xd

Re: [PATCH net-next v6 3/3] selftests: drv-net: Test queue xsk attribute

2025-02-11 Thread Joe Damato
On Tue, Feb 11, 2025 at 12:09:50PM +0100, Paolo Abeni wrote: > On 2/10/25 8:38 PM, Joe Damato wrote: > > +def check_xdp(cfg, nl, xdp_queue_id=0) -> None: > > +test_dir = os.path.dirname(os.path.realpath(__file__)) > > +xdp = subprocess.Popen([f"{test_dir}/xdp_helper", f"{cfg.ifindex}", > >

Re: [PATCH net-next v6 3/3] selftests: drv-net: Test queue xsk attribute

2025-02-11 Thread Paolo Abeni
On 2/10/25 8:38 PM, Joe Damato wrote: > +def check_xdp(cfg, nl, xdp_queue_id=0) -> None: > +test_dir = os.path.dirname(os.path.realpath(__file__)) > +xdp = subprocess.Popen([f"{test_dir}/xdp_helper", f"{cfg.ifindex}", > f"{xdp_queue_id}"], > + stdin=subprocess.PIP

[PATCH net-next v6 3/3] selftests: drv-net: Test queue xsk attribute

2025-02-10 Thread Joe Damato
Test that queues which are used for AF_XDP have the xsk nest attribute. The attribute is currently empty, but its existence means the AF_XDP is being used for the queue. Signed-off-by: Joe Damato Suggested-by: Jakub Kicinski --- v3: - Change comment style of helper C program to avoid kdoc wa