Re: [PATCH net-next v7 06/17] ethtool: netlink bitset handling

2019-10-21 Thread Michal Kubecek
On Mon, Oct 14, 2019 at 03:02:05PM +0200, Jiri Pirko wrote: > Mon, Oct 14, 2019 at 01:18:47PM CEST, mkube...@suse.cz wrote: > >On Fri, Oct 11, 2019 at 03:34:29PM +0200, Jiri Pirko wrote: > >> Wed, Oct 09, 2019 at 10:59:18PM CEST, mkube...@suse.cz wrote: > >> >+Bit sets > >> >+ > >> >+ > >>

Re: [PATCH net-next v7 06/17] ethtool: netlink bitset handling

2019-10-14 Thread Jiri Pirko
Mon, Oct 14, 2019 at 01:18:47PM CEST, mkube...@suse.cz wrote: >On Fri, Oct 11, 2019 at 03:34:29PM +0200, Jiri Pirko wrote: >> Wed, Oct 09, 2019 at 10:59:18PM CEST, mkube...@suse.cz wrote: >> >+Bit sets >> >+ >> >+ >> >+For short bitmaps of (reasonably) fixed length, standard

Re: [PATCH net-next v7 06/17] ethtool: netlink bitset handling

2019-10-14 Thread Michal Kubecek
On Fri, Oct 11, 2019 at 03:34:29PM +0200, Jiri Pirko wrote: > Wed, Oct 09, 2019 at 10:59:18PM CEST, mkube...@suse.cz wrote: > >+Bit sets > >+ > >+ > >+For short bitmaps of (reasonably) fixed length, standard ``NLA_BITFIELD32`` > >+type is used. For arbitrary length bitmaps, ethtool netlink

Re: [PATCH net-next v7 06/17] ethtool: netlink bitset handling

2019-10-11 Thread Jiri Pirko
Wed, Oct 09, 2019 at 10:59:18PM CEST, mkube...@suse.cz wrote: >The ethtool netlink code uses common framework for passing arbitrary >length bit sets to allow future extensions. A bitset can be a list (only >one bitmap) or can consist of value and mask pair (used e.g. when client >want to modify

[PATCH net-next v7 06/17] ethtool: netlink bitset handling

2019-10-09 Thread Michal Kubecek
The ethtool netlink code uses common framework for passing arbitrary length bit sets to allow future extensions. A bitset can be a list (only one bitmap) or can consist of value and mask pair (used e.g. when client want to modify only some bits). A bitset can use one of two formats: verbose (bit