Re: [PATCH net-next v7 12/17] ethtool: provide link settings with LINKINFO_GET request

2019-10-10 Thread Michal Kubecek
On Thu, Oct 10, 2019 at 05:59:55PM +0200, Jiri Pirko wrote: > Wed, Oct 09, 2019 at 10:59:37PM CEST, mkube...@suse.cz wrote: > > [...] > > >+/* prepare_data() handler */ > > Not sure how valuable are comments like this... I'll drop them. > >+static int linkinfo_prepare(const struct

Re: [PATCH net-next v7 12/17] ethtool: provide link settings with LINKINFO_GET request

2019-10-10 Thread Jiri Pirko
Wed, Oct 09, 2019 at 10:59:37PM CEST, mkube...@suse.cz wrote: [...] >+/* prepare_data() handler */ Not sure how valuable are comments like this... >+static int linkinfo_prepare(const struct ethnl_req_info *req_base, >+ struct ethnl_reply_data *reply_base, >+

[PATCH net-next v7 12/17] ethtool: provide link settings with LINKINFO_GET request

2019-10-09 Thread Michal Kubecek
Implement LINKINFO_GET netlink request to get basic link settings provided by ETHTOOL_GLINKSETTINGS and ETHTOOL_GSET ioctl commands. This request provides settings not directly related to autonegotiation and link mode selection: physical port, phy MDIO address, MDI(-X) status, MDI(-X) control and