Re: [PATCH net-next v7 14/17] ethtool: set link settings with LINKINFO_SET request

2019-10-14 Thread Michal Kubecek
On Sat, Oct 12, 2019 at 06:33:09PM +0200, Jiri Pirko wrote: > Wed, Oct 09, 2019 at 10:59:43PM CEST, mkube...@suse.cz wrote: > > [...] > > >+static const struct nla_policy linkinfo_hdr_policy[ETHTOOL_A_HEADER_MAX + > >1] = { > >+[ETHTOOL_A_HEADER_UNSPEC] = { .type = NLA_REJECT

Re: [PATCH net-next v7 14/17] ethtool: set link settings with LINKINFO_SET request

2019-10-12 Thread Jiri Pirko
Wed, Oct 09, 2019 at 10:59:43PM CEST, mkube...@suse.cz wrote: [...] >+static const struct nla_policy linkinfo_hdr_policy[ETHTOOL_A_HEADER_MAX + 1] >= { >+ [ETHTOOL_A_HEADER_UNSPEC] = { .type = NLA_REJECT }, >+ [ETHTOOL_A_HEADER_DEV_INDEX]= { .type = NLA_U32

Re: [PATCH net-next v7 14/17] ethtool: set link settings with LINKINFO_SET request

2019-10-11 Thread Jiri Pirko
Thu, Oct 10, 2019 at 09:30:44PM CEST, mkube...@suse.cz wrote: >On Thu, Oct 10, 2019 at 05:37:54PM +0200, Jiri Pirko wrote: >> Wed, Oct 09, 2019 at 10:59:43PM CEST, mkube...@suse.cz wrote: >> >Implement LINKINFO_SET netlink request to set link settings queried by >> >LINKINFO_GET message. >> > >>

Re: [PATCH net-next v7 14/17] ethtool: set link settings with LINKINFO_SET request

2019-10-10 Thread Michal Kubecek
On Thu, Oct 10, 2019 at 05:37:54PM +0200, Jiri Pirko wrote: > Wed, Oct 09, 2019 at 10:59:43PM CEST, mkube...@suse.cz wrote: > >Implement LINKINFO_SET netlink request to set link settings queried by > >LINKINFO_GET message. > > > >Only physical port, phy MDIO address and MDI(-X) control can be set,

Re: [PATCH net-next v7 14/17] ethtool: set link settings with LINKINFO_SET request

2019-10-10 Thread Jiri Pirko
Wed, Oct 09, 2019 at 10:59:43PM CEST, mkube...@suse.cz wrote: >Implement LINKINFO_SET netlink request to set link settings queried by >LINKINFO_GET message. > >Only physical port, phy MDIO address and MDI(-X) control can be set, >attempt to modify MDI(-X) status and transceiver is rejected. >

[PATCH net-next v7 14/17] ethtool: set link settings with LINKINFO_SET request

2019-10-09 Thread Michal Kubecek
Implement LINKINFO_SET netlink request to set link settings queried by LINKINFO_GET message. Only physical port, phy MDIO address and MDI(-X) control can be set, attempt to modify MDI(-X) status and transceiver is rejected. When any data is modified, ETHTOOL_MSG_LINKINFO_NTF message in the same