Re: [PATCH net-next v7 28/28] net: WireGuard secure network tunnel

2018-10-10 Thread Jiri Pirko
Wed, Oct 10, 2018 at 10:27:46PM CEST, ja...@zx2c4.com wrote: >Hey Jiri, > >Actually, in the end I went with the suggestion from Andrew and Lukas, >which is to follow Dan's guideline: >https://lkml.org/lkml/2016/8/22/374 . It looks like this: >

Re: [PATCH net-next v7 28/28] net: WireGuard secure network tunnel

2018-10-10 Thread Jiri Pirko
Wed, Oct 10, 2018 at 10:27:46PM CEST, ja...@zx2c4.com wrote: >Hey Jiri, > >Actually, in the end I went with the suggestion from Andrew and Lukas, >which is to follow Dan's guideline: >https://lkml.org/lkml/2016/8/22/374 . It looks like this: >

Re: [PATCH net-next v7 28/28] net: WireGuard secure network tunnel

2018-10-07 Thread Jason A. Donenfeld
Hi Andrew, On Sun, Oct 7, 2018 at 6:48 PM Andrew Lunn wrote: > Hi Jason > > This is the sort of thing you should state in the patchset version > history. It is O.K. to say i will address this later, but you need to > communicate that. Otherwise reviewers just get frustrated that > comments are

Re: [PATCH net-next v7 28/28] net: WireGuard secure network tunnel

2018-10-07 Thread Jason A. Donenfeld
Hi Andrew, On Sun, Oct 7, 2018 at 6:48 PM Andrew Lunn wrote: > Hi Jason > > This is the sort of thing you should state in the patchset version > history. It is O.K. to say i will address this later, but you need to > communicate that. Otherwise reviewers just get frustrated that > comments are