Re: [PATCH net 0/5] Implement ndo_gso_check() for vxlan nics

2014-11-06 Thread Jesse Gross
On Thu, Nov 6, 2014 at 8:06 AM, Tom Herbert wrote: > On Wed, Nov 5, 2014 at 10:16 PM, Sathya Perla wrote: >>> -Original Message- >>> From: Tom Herbert [mailto:therb...@google.com] >>> >>> On Wed, Nov 5, 2014 at 6:15 PM, David Miller >>> wrote: >>> > From: Joe Stringer >>> > Date: Wed, 5

Re: [PATCH net 0/5] Implement ndo_gso_check() for vxlan nics

2014-11-06 Thread Tom Herbert
The inner headers are reset in iptunnel_handle_offloads. This called in the xmit encapsulation function (GRE, fou, VXLAN, etc.) before added in encapsulation headers, so the inner headers will point to the encapsulation payload, i.e. the encapsulated packet. The headers are only on the first encaps

Re: [PATCH net 0/5] Implement ndo_gso_check() for vxlan nics

2014-11-06 Thread Or Gerlitz
On Thu, Nov 6, 2014 at 4:44 AM, Tom Herbert wrote: > On Wed, Nov 5, 2014 at 6:15 PM, David Miller wrote: >> From: Joe Stringer >> Date: Wed, 5 Nov 2014 17:06:46 -0800 >> >>> My impression was that the changes are more likely to be >>> hardware-specific (like the i40e changes) rather than softwar

Re: [PATCH net 0/5] Implement ndo_gso_check() for vxlan nics

2014-11-05 Thread Tom Herbert
On Wed, Nov 5, 2014 at 6:15 PM, David Miller wrote: > From: Joe Stringer > Date: Wed, 5 Nov 2014 17:06:46 -0800 > >> My impression was that the changes are more likely to be >> hardware-specific (like the i40e changes) rather than software-specific, >> like changes that might be integrated into t

Re: [PATCH net 0/5] Implement ndo_gso_check() for vxlan nics

2014-11-05 Thread David Miller
From: Joe Stringer Date: Wed, 5 Nov 2014 17:06:46 -0800 > My impression was that the changes are more likely to be > hardware-specific (like the i40e changes) rather than software-specific, > like changes that might be integrated into the helper. I think there is more commonality amongst hardwar

Re: [PATCH net 0/5] Implement ndo_gso_check() for vxlan nics

2014-11-05 Thread Joe Stringer
On Wed, Nov 05, 2014 at 04:38:25PM -0500, David Miller wrote: > From: Or Gerlitz > Date: Wed, 5 Nov 2014 23:32:44 +0200 > > > but fact is that the proposed patch series has the --same-- helper for > > four drivers, so why not start with a that limited helper which would > > be picked up by these

Re: [PATCH net 0/5] Implement ndo_gso_check() for vxlan nics

2014-11-05 Thread David Miller
From: Or Gerlitz Date: Wed, 5 Nov 2014 23:32:44 +0200 > but fact is that the proposed patch series has the --same-- helper for > four drivers, so why not start with a that limited helper which would > be picked up by these drivers and we'll take it from there. I'm in favor of the helper, duplica

Re: [PATCH net 0/5] Implement ndo_gso_check() for vxlan nics

2014-11-05 Thread Or Gerlitz
On Wed, Nov 5, 2014 at 8:00 PM, Tom Herbert wrote: > On Wed, Nov 5, 2014 at 9:50 AM, Joe Stringer wrote: >> >> On 5 November 2014 04:38, Or Gerlitz wrote: >>> >>> On Tue, Nov 4, 2014 at 11:56 PM, Joe Stringer >>> wrote: >>> > Most NICs that report NETIF_F_GSO_UDP_TUNNEL support VXLAN, and not

Re: [PATCH net 0/5] Implement ndo_gso_check() for vxlan nics

2014-11-05 Thread Tom Herbert
On Wed, Nov 5, 2014 at 9:50 AM, Joe Stringer wrote: > > On 5 November 2014 04:38, Or Gerlitz wrote: >> >> On Tue, Nov 4, 2014 at 11:56 PM, Joe Stringer wrote: >> > Most NICs that report NETIF_F_GSO_UDP_TUNNEL support VXLAN, and not other >> > UDP-based encapsulation protocols where the format an

Re: [PATCH net 0/5] Implement ndo_gso_check() for vxlan nics

2014-11-05 Thread Or Gerlitz
On Tue, Nov 4, 2014 at 11:56 PM, Joe Stringer wrote: > Most NICs that report NETIF_F_GSO_UDP_TUNNEL support VXLAN, and not other > UDP-based encapsulation protocols where the format and size of the header may > differ. This patch series implements ndo_gso_check() for these NICs, > restricting the

[PATCH net 0/5] Implement ndo_gso_check() for vxlan nics

2014-11-04 Thread Joe Stringer
Most NICs that report NETIF_F_GSO_UDP_TUNNEL support VXLAN, and not other UDP-based encapsulation protocols where the format and size of the header may differ. This patch series implements ndo_gso_check() for these NICs, restricting the GSO handling to something that looks and smells like VXLAN. I