Re: [PATCH net 1/2] net: phy: Use C45 Helpers in phy_read_status()

2019-03-02 Thread Heiner Kallweit
On 02.03.2019 15:11, Andrew Lunn wrote: > On Fri, Mar 01, 2019 at 07:14:20PM -0800, Florian Fainelli wrote: >> >> >> On 3/1/2019 2:54 AM, Jose Abreu wrote: >>> Currently phy_read_status() considers that either the PHY driver has the >>> read_status() callback or uses the generic callback. >>> >>> F

Re: [PATCH net 1/2] net: phy: Use C45 Helpers in phy_read_status()

2019-03-02 Thread Andrew Lunn
On Fri, Mar 01, 2019 at 07:14:20PM -0800, Florian Fainelli wrote: > > > On 3/1/2019 2:54 AM, Jose Abreu wrote: > > Currently phy_read_status() considers that either the PHY driver has the > > read_status() callback or uses the generic callback. > > > > For C45 PHYs we need to use the gen10g_read

Re: [PATCH net 1/2] net: phy: Use C45 Helpers in phy_read_status()

2019-03-01 Thread Florian Fainelli
On 3/1/2019 2:54 AM, Jose Abreu wrote: > Currently phy_read_status() considers that either the PHY driver has the > read_status() callback or uses the generic callback. > > For C45 PHYs we need to use the gen10g_read_status() callback. Right, so we could expect your C45 PHY driver to assign th

[PATCH net 1/2] net: phy: Use C45 Helpers in phy_read_status()

2019-03-01 Thread Jose Abreu
Currently phy_read_status() considers that either the PHY driver has the read_status() callback or uses the generic callback. For C45 PHYs we need to use the gen10g_read_status() callback. Signed-off-by: Jose Abreu Cc: Andrew Lunn Cc: Florian Fainelli Cc: "David S. Miller" Cc: Joao Pinto ---