Re: [PATCH net 1/4] net: stmmac: dwmac-sun8i: Fix probe error handling

2021-01-04 Thread Chen-Yu Tsai
On Sun, Jan 3, 2021 at 7:17 PM Samuel Holland wrote: > > stmmac_pltfr_remove does three things in one function, making it > inapproprate for unwinding the steps in the probe function. Currently, > a failure before the call to stmmac_dvr_probe would leak OF node > references due to missing a call t

[PATCH net 1/4] net: stmmac: dwmac-sun8i: Fix probe error handling

2021-01-03 Thread Samuel Holland
stmmac_pltfr_remove does three things in one function, making it inapproprate for unwinding the steps in the probe function. Currently, a failure before the call to stmmac_dvr_probe would leak OF node references due to missing a call to stmmac_remove_config_dt. And an error in stmmac_dvr_probe woul