RE: [PATCH net 2/3] r8152: fix remote wakeup

2015-07-23 Thread Hayes Wang
Oliver Neukum [mailto:oneu...@suse.com] [...] > If the device does not support remote wakeup and the driver enables it, > runtime > power management will be switched off. > That is the current state and it means that devices which don't support remote > wakeup cannot do runtime power management at

Re: [PATCH net 2/3] r8152: fix remote wakeup

2015-07-23 Thread Oliver Neukum
On Thu, 2015-07-23 at 09:55 +, Hayes Wang wrote: > > Hi, > > > > this is most likely wrong. Usbcore does check for a device's ability to > > do remote wakeup and will block a runtime suspend if it detects that > > a remote wakeup would be required but the device cannot deliver. > > (static int

RE: [PATCH net 2/3] r8152: fix remote wakeup

2015-07-23 Thread Hayes Wang
> Hi, > > this is most likely wrong. Usbcore does check for a device's ability to > do remote wakeup and will block a runtime suspend if it detects that > a remote wakeup would be required but the device cannot deliver. > (static int autosuspend_check()) > > So by removing the flag in the probe()

Re: [PATCH net 2/3] r8152: fix remote wakeup

2015-07-23 Thread Oliver Neukum
On Thu, 2015-07-23 at 15:09 +0800, Hayes Wang wrote: > Set needs_remote_wakeup only when the device supports it. > > Signed-off-by: Hayes Wang > --- > drivers/net/usb/r8152.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r81

[PATCH net 2/3] r8152: fix remote wakeup

2015-07-23 Thread Hayes Wang
Set needs_remote_wakeup only when the device supports it. Signed-off-by: Hayes Wang --- drivers/net/usb/r8152.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index e3a0110..eff1f25 100644 --- a/drivers/net/usb/r8152.c +++