[PATCH net 3/3] net: ethtool: sync netdev_features_strings order with enum netdev_features

2020-06-19 Thread Alexander Lobakin
The ordering of netdev_features_strings[] makes no sense when it comes to user interaction, as list of features in `ethtool -k` input is sorted according to the corresponding bit's position. Instead, it *does* make sense when it comes to adding new netdev_features or modifying existing ones. We hav

[PATCH net 3/3] net: ethtool: sync netdev_features_strings order with enum netdev_features

2020-06-19 Thread Alexander Lobakin
The ordering of netdev_features_strings[] makes no sense when it comes to user interaction, as list of features in `ethtool -k` input is sorted according to the corresponding bit's position. Instead, it *does* make sense when it comes to adding new netdev_features or modifying existing ones. We hav

Re: [PATCH net 3/3] net: ethtool: sync netdev_features_strings order with enum netdev_features

2020-06-22 Thread Michal Kubecek
On Fri, Jun 19, 2020 at 06:39:59PM +, Alexander Lobakin wrote: > The ordering of netdev_features_strings[] makes no sense when it comes > to user interaction, as list of features in `ethtool -k` input is sorted > according to the corresponding bit's position. > Instead, it *does* make sense whe