Re: [PATCH net 3/4] net: ipa: use the right accessor in ipa_endpoint_status_skip()

2021-02-01 Thread Amy Parker
On Mon, Feb 1, 2021 at 4:15 PM Alex Elder wrote: > > On 2/1/21 6:02 PM, Amy Parker wrote: > > On Mon, Feb 1, 2021 at 3:32 PM Alex Elder wrote: > >> > >> When extracting the destination endpoint ID from the status in > >> ipa_endpoint_status_skip(), u32_get_bits() is used. This happens to > >>

Re: [PATCH net 3/4] net: ipa: use the right accessor in ipa_endpoint_status_skip()

2021-02-01 Thread Alex Elder
On 2/1/21 6:02 PM, Amy Parker wrote: On Mon, Feb 1, 2021 at 3:32 PM Alex Elder wrote: When extracting the destination endpoint ID from the status in ipa_endpoint_status_skip(), u32_get_bits() is used. This happens to work, but it's wrong: the structure field is only 8 bits wide instead of

Re: [PATCH net 3/4] net: ipa: use the right accessor in ipa_endpoint_status_skip()

2021-02-01 Thread Amy Parker
On Mon, Feb 1, 2021 at 4:02 PM Amy Parker wrote: > > Fix this by using u8_get_bits() to get the destination endpoint ID. > > Isn't > Apologies about this - premature email sending. This was simply going to be "Isn't endpoint_id u32?", which was addressed later anyways. Best regards, Amy Parker

Re: [PATCH net 3/4] net: ipa: use the right accessor in ipa_endpoint_status_skip()

2021-02-01 Thread Amy Parker
On Mon, Feb 1, 2021 at 3:32 PM Alex Elder wrote: > > When extracting the destination endpoint ID from the status in > ipa_endpoint_status_skip(), u32_get_bits() is used. This happens to > work, but it's wrong: the structure field is only 8 bits wide > instead of 32. > > Fix this by using

[PATCH net 3/4] net: ipa: use the right accessor in ipa_endpoint_status_skip()

2021-02-01 Thread Alex Elder
When extracting the destination endpoint ID from the status in ipa_endpoint_status_skip(), u32_get_bits() is used. This happens to work, but it's wrong: the structure field is only 8 bits wide instead of 32. Fix this by using u8_get_bits() to get the destination endpoint ID. Signed-off-by: Alex