Re: [PATCH net v2] lan743x: fix rx_napi_poll/interrupt ping-pong

2020-12-11 Thread Heiner Kallweit
Am 11.12.2020 um 13:43 schrieb Sven Van Asbroeck: > Hi Heiner, > > On Thu, Dec 10, 2020 at 2:32 AM Heiner Kallweit wrote: >> >> >> In addition you could play with sysfs attributes >> /sys/class/net//gro_flush_timeout >> /sys/class/net//napi_defer_hard_irqs > > Interesting, I will look into

Re: [PATCH net v2] lan743x: fix rx_napi_poll/interrupt ping-pong

2020-12-11 Thread Sven Van Asbroeck
Hi Heiner, On Thu, Dec 10, 2020 at 2:32 AM Heiner Kallweit wrote: > > > In addition you could play with sysfs attributes > /sys/class/net//gro_flush_timeout > /sys/class/net//napi_defer_hard_irqs Interesting, I will look into that. > > @@ -2407,7 +2409,7 @@ static int lan743x_rx_open(struct

Re: [PATCH net v2] lan743x: fix rx_napi_poll/interrupt ping-pong

2020-12-09 Thread Heiner Kallweit
Am 10.12.2020 um 04:55 schrieb Sven Van Asbroeck: > From: Sven Van Asbroeck > > Even if there is more rx data waiting on the chip, the rx napi poll fn > will never run more than once - it will always read a few buffers, then > bail out and re-arm interrupts. Which results in ping-pong between

[PATCH net v2] lan743x: fix rx_napi_poll/interrupt ping-pong

2020-12-09 Thread Sven Van Asbroeck
From: Sven Van Asbroeck Even if there is more rx data waiting on the chip, the rx napi poll fn will never run more than once - it will always read a few buffers, then bail out and re-arm interrupts. Which results in ping-pong between napi and interrupt. This defeats the purpose of napi, and is