Re: [PATCH net v2 3/9] net/mac89x0: Fix and modernize log messages

2017-10-06 Thread Finn Thain
On Thu, 5 Oct 2017, David Miller wrote: > From: Finn Thain > Date: Thu, 5 Oct 2017 21:11:05 -0400 (EDT) > > > Fix misplaced newlines in conditional log messages. > > Please don't do this, the way the author formatted the strings was > intentional, they intended to print out: > > NAME: c

Re: [PATCH net v2 3/9] net/mac89x0: Fix and modernize log messages

2017-10-05 Thread David Miller
From: Finn Thain Date: Thu, 5 Oct 2017 21:11:05 -0400 (EDT) > Fix misplaced newlines in conditional log messages. Please don't do this, the way the author formatted the strings was intentional, they intended to print out: NAME: cs89%c0%s rev %c found at %#8lx IRQ %d ADDR %pM But now y

[PATCH net v2 3/9] net/mac89x0: Fix and modernize log messages

2017-10-05 Thread Finn Thain
Fix misplaced newlines in conditional log messages. Add missing printk severity levels. Log the MAC address after the interface gets a meaningful name. Drop deprecated "out of memory" message as per checkpatch advice. Signed-off-by: Finn Thain --- drivers/net/ethernet/cirrus/mac89x0.c | 26 +