Re: [PATCH net v3] net: phy: realtek: fix rtl8211e rx/tx delay config

2020-09-28 Thread Jakub Kicinski
On Mon, 28 Sep 2020 13:52:23 +0800 Willy Liu wrote: > diff --git a/drivers/net/phy/realtek.c b/drivers/net/phy/realtek.c > old mode 100644 > new mode 100755 Please don't change the file mode to executable. Checkpatch should warn you about this.

[PATCH net v3] net: phy: realtek: fix rtl8211e rx/tx delay config

2020-09-27 Thread Willy Liu
There are two chip pins named TXDLY and RXDLY which actually adds the 2ns delays to TXC and RXC for TXD/RXD latching. These two pins can config via 4.7k-ohm resistor to 3.3V hw setting, but also config via software setting (extension page 0xa4 register 0x1c bit13 12 and 11). The configuration regi