Re: [PATCH next] fs/splice: iter_to_pipe -- Use PIPE_DEF_BUFFERS instead of hardcoded number

On Wed, Jan 30, 2019 at 06:48:51PM +0300, Cyrill Gorcunov wrote: > On Wed, Jan 30, 2019 at 03:42:45PM +, Al Viro wrote: > > On Wed, Jan 30, 2019 at 06:39:11PM +0300, Cyrill Gorcunov wrote: > > > And use ARRAY_SIZE for easier code modification if we ever need in future. > > > > Umm... Why

Re: [PATCH next] fs/splice: iter_to_pipe -- Use PIPE_DEF_BUFFERS instead of hardcoded number

On Wed, Jan 30, 2019 at 03:42:45PM +, Al Viro wrote: > On Wed, Jan 30, 2019 at 06:39:11PM +0300, Cyrill Gorcunov wrote: > > And use ARRAY_SIZE for easier code modification if we ever need in future. > > Umm... Why PIPE_DEF_BUFFERS, though? Because it's a constant from more or > less the

Re: [PATCH next] fs/splice: iter_to_pipe -- Use PIPE_DEF_BUFFERS instead of hardcoded number

On Wed, Jan 30, 2019 at 06:39:11PM +0300, Cyrill Gorcunov wrote: > And use ARRAY_SIZE for easier code modification if we ever need in future. Umm... Why PIPE_DEF_BUFFERS, though? Because it's a constant from more or less the same area that happens to be equal to the value we use here?

[PATCH next] fs/splice: iter_to_pipe -- Use PIPE_DEF_BUFFERS instead of hardcoded number

And use ARRAY_SIZE for easier code modification if we ever need in future. CC: Al Viro Signed-off-by: Cyrill Gorcunov --- fs/splice.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: linux-next.git/fs/splice.c