Re: [PATCH part1 v6 5/7] PCI: Add pci_dummy_ops to isolate pci device temporarily

2014-02-12 Thread Yijing Wang
>> +void pci_bus_unfreeze_device(struct pci_bus *bus) >> +{ >> +unsigned long flags; >> + >> +BUG_ON(!bus->save_ops); >> +spin_lock_irqsave(&pci_freeze_lock, flags); >> +if (!bus->is_frozen) >> +goto out; > > It seems that the BUG_ON() should placed here, otherwise it w

Re: [PATCH part1 v6 5/7] PCI: Add pci_dummy_ops to isolate pci device temporarily

2014-02-11 Thread Gu Zheng
Hi Yijing, On 02/12/2014 10:52 AM, Yijing Wang wrote: > Pci_dummy_ops does nothing when we use it to read/write > pci_device. So we can isolate pci device by replace its > bus pci_ops by pci_dummy_ops. This is preparation for > the later patch. > > Signed-off-by: Yijing Wang > --- > drivers/pci

[PATCH part1 v6 5/7] PCI: Add pci_dummy_ops to isolate pci device temporarily

2014-02-11 Thread Yijing Wang
Pci_dummy_ops does nothing when we use it to read/write pci_device. So we can isolate pci device by replace its bus pci_ops by pci_dummy_ops. This is preparation for the later patch. Signed-off-by: Yijing Wang --- drivers/pci/pci.c | 62 +++ in