On 08/12/2013 10:21 PM, Tejun Heo wrote:
On Thu, Aug 08, 2013 at 07:09:53AM -0700, Joe Perches wrote:
If you really think that the #define is better, use
something like HW_ERR does and embed that #define
in the pr_err.
#define ACPI_OVERRIDE "ACPI OVERRIDE: "
pr_err(ACPI_OVERRIDE
On Thu, Aug 08, 2013 at 07:09:53AM -0700, Joe Perches wrote:
> If you really think that the #define is better, use
> something like HW_ERR does and embed that #define
> in the pr_err.
>
> #define ACPI_OVERRIDE "ACPI OVERRIDE: "
>
> pr_err(ACPI_OVERRIDE "Table smaller than ACPI header
On Thu, Aug 08, 2013 at 07:09:53AM -0700, Joe Perches wrote:
If you really think that the #define is better, use
something like HW_ERR does and embed that #define
in the pr_err.
#define ACPI_OVERRIDE ACPI OVERRIDE:
pr_err(ACPI_OVERRIDE Table smaller than ACPI header [%s%s]\n,
On 08/12/2013 10:21 PM, Tejun Heo wrote:
On Thu, Aug 08, 2013 at 07:09:53AM -0700, Joe Perches wrote:
If you really think that the #define is better, use
something like HW_ERR does and embed that #define
in the pr_err.
#define ACPI_OVERRIDE ACPI OVERRIDE:
pr_err(ACPI_OVERRIDE Table
On Thu, 2013-08-08 at 20:18 +0800, Tang Chen wrote:
> Hi Joe,
Hello Tang.
> On 08/08/2013 01:27 PM, Joe Perches wrote:
> > On Thu, 2013-08-08 at 13:03 +0800, Tang Chen wrote:
> >
> >> Change it to the style like other macros:
> >>
> >> #define INVALID_TABLE(x, path, name)
Hi Joe,
On 08/08/2013 01:27 PM, Joe Perches wrote:
On Thu, 2013-08-08 at 13:03 +0800, Tang Chen wrote:
Change it to the style like other macros:
#define INVALID_TABLE(x, path, name)\
do { pr_err("ACPI OVERRIDE: " x " [%s%s]\n", path, name); }
Hi Joe,
On 08/08/2013 01:27 PM, Joe Perches wrote:
On Thu, 2013-08-08 at 13:03 +0800, Tang Chen wrote:
Change it to the style like other macros:
#define INVALID_TABLE(x, path, name)\
do { pr_err(ACPI OVERRIDE: x [%s%s]\n, path, name); }
On Thu, 2013-08-08 at 20:18 +0800, Tang Chen wrote:
Hi Joe,
Hello Tang.
On 08/08/2013 01:27 PM, Joe Perches wrote:
On Thu, 2013-08-08 at 13:03 +0800, Tang Chen wrote:
Change it to the style like other macros:
#define INVALID_TABLE(x, path, name)\
On Thu, 2013-08-08 at 13:03 +0800, Tang Chen wrote:
> Change it to the style like other macros:
>
> #define INVALID_TABLE(x, path, name)\
> do { pr_err("ACPI OVERRIDE: " x " [%s%s]\n", path, name); } while (0)
Single statement macros do _not_ need
The macro INVALID_TABLE() is defined like this:
#define INVALID_TABLE(x, path, name)\
{ pr_err("ACPI OVERRIDE: " x " [%s%s]\n", path, name); continue; }
And it is used like this:
for (...) {
...
if (...)
The macro INVALID_TABLE() is defined like this:
#define INVALID_TABLE(x, path, name)\
{ pr_err(ACPI OVERRIDE: x [%s%s]\n, path, name); continue; }
And it is used like this:
for (...) {
...
if (...)
On Thu, 2013-08-08 at 13:03 +0800, Tang Chen wrote:
Change it to the style like other macros:
#define INVALID_TABLE(x, path, name)\
do { pr_err(ACPI OVERRIDE: x [%s%s]\n, path, name); } while (0)
Single statement macros do _not_ need to use
12 matches
Mail list logo
