RE: [PATCH perf 3/4] perf tools: Fix unused variables: x86_{32,64}_regoffset_table

2016-01-22 Thread 平松雅巳 / HIRAMATU,MASAMI
>From: Wangnan (F) [mailto:wangn...@huawei.com] >On 2016/1/22 13:56, 平松雅巳 / HIRAMATU,MASAMI wrote: >>> From: Wangnan (F) [mailto:wangn...@huawei.com] >>> I think this problem is not introduced by my patch. In fact >>> there's a fundamental problem in get_arch_regstr() that it is >>> impossible to s

Re: [PATCH perf 3/4] perf tools: Fix unused variables: x86_{32,64}_regoffset_table

2016-01-21 Thread Wangnan (F)
On 2016/1/22 13:56, 平松雅巳 / HIRAMATU,MASAMI wrote: From: Wangnan (F) [mailto:wangn...@huawei.com] On 2016/1/20 21:59, Arnaldo Carvalho de Melo wrote: Em Tue, Jan 19, 2016 at 09:33:06PM +, Ben Hutchings escreveu: gcc 5 doesn't seem to care about these, but gcc 6 does and that results in a

RE: [PATCH perf 3/4] perf tools: Fix unused variables: x86_{32,64}_regoffset_table

2016-01-21 Thread 平松雅巳 / HIRAMATU,MASAMI
>From: Wangnan (F) [mailto:wangn...@huawei.com] > >On 2016/1/20 21:59, Arnaldo Carvalho de Melo wrote: >> Em Tue, Jan 19, 2016 at 09:33:06PM +, Ben Hutchings escreveu: >>> gcc 5 doesn't seem to care about these, but gcc 6 does and that >>> results in a build failure. >> Ben, please CC the peopl

Re: [PATCH perf 3/4] perf tools: Fix unused variables: x86_{32,64}_regoffset_table

2016-01-21 Thread Wangnan (F)
On 2016/1/21 23:41, Arnaldo Carvalho de Melo wrote: But... I think that the unflexible original code has a bug, one that makes it not work when using gcc6 :-\ So I think we should make it build in gcc6, using that patch (or does it have some other problem?) so that at least doing what we can

Re: [PATCH perf 3/4] perf tools: Fix unused variables: x86_{32,64}_regoffset_table

2016-01-21 Thread Arnaldo Carvalho de Melo
Em Thu, Jan 21, 2016 at 12:38:48PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Thu, Jan 21, 2016 at 12:43:04PM +0800, Wangnan (F) escreveu: > > I think this problem is not introduced by my patch. In fact > > there's a fundamental problem in get_arch_regstr() that it is > > impossible to switch s

Re: [PATCH perf 3/4] perf tools: Fix unused variables: x86_{32,64}_regoffset_table

2016-01-21 Thread Arnaldo Carvalho de Melo
Em Thu, Jan 21, 2016 at 12:43:04PM +0800, Wangnan (F) escreveu: > I think this problem is not introduced by my patch. In fact > there's a fundamental problem in get_arch_regstr() that it is > impossible to switch sub ISA. > Not only x86_64 and x86_32, I think on arm64 we also have this > problem w

Re: [PATCH perf 3/4] perf tools: Fix unused variables: x86_{32,64}_regoffset_table

2016-01-20 Thread Wangnan (F)
On 2016/1/20 21:59, Arnaldo Carvalho de Melo wrote: Em Tue, Jan 19, 2016 at 09:33:06PM +, Ben Hutchings escreveu: gcc 5 doesn't seem to care about these, but gcc 6 does and that results in a build failure. Ben, please CC the people on the CC list for the patch that introduces the problem,