Re: [PATCH rc4-mm1] drivers/char/isicom.c old api rewritten

2005-08-06 Thread Jiri Slaby
Domen Puncer napsal(a): You have much bigger chances of someone reviewing the patch if you at least split code changes and whitespace/type cleanups. 65k is a lot. Ok, 3 patches: http://www.fi.muni.cz/~xslaby/lnx/isi_main.txt this changes many lines of code, adds hotplug, firmware loading,

Re: [PATCH rc4-mm1] drivers/char/isicom.c old api rewritten

2005-08-06 Thread Domen Puncer
On 02/08/05 00:02 +0200, Jiri Slaby wrote: > Hello. > Could you send me critics and bugs? You have much bigger chances of someone reviewing the patch if you at least split code changes and whitespace/type cleanups. 65k is a lot. > Could somebody test it (but NOT now)? > Thanks. > >

Re: [PATCH rc4-mm1] drivers/char/isicom.c old api rewritten

2005-08-06 Thread Domen Puncer
On 02/08/05 00:02 +0200, Jiri Slaby wrote: Hello. Could you send me critics and bugs? You have much bigger chances of someone reviewing the patch if you at least split code changes and whitespace/type cleanups. 65k is a lot. Could somebody test it (but NOT now)? Thanks.

Re: [PATCH rc4-mm1] drivers/char/isicom.c old api rewritten

2005-08-06 Thread Jiri Slaby
Domen Puncer napsal(a): You have much bigger chances of someone reviewing the patch if you at least split code changes and whitespace/type cleanups. 65k is a lot. Ok, 3 patches: http://www.fi.muni.cz/~xslaby/lnx/isi_main.txt this changes many lines of code, adds hotplug, firmware loading,

Re: [PATCH rc4-mm1] drivers/char/isicom.c old api rewritten

2005-08-05 Thread Jiri Slaby
Jiri Slaby napsal(a): Could somebody test it (but NOT now)? Ok, could anybody test it now, if no problems were discovered, please? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH rc4-mm1] drivers/char/isicom.c old api rewritten

2005-08-05 Thread Jiri Slaby
Jiri Slaby napsal(a): Could somebody test it (but NOT now)? Ok, could anybody test it now, if no problems were discovered, please? - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at

[PATCH rc4-mm1] drivers/char/isicom.c old api rewritten

2005-08-01 Thread Jiri Slaby
Hello. Could you send me critics and bugs? Could somebody test it (but NOT now)? Thanks. drivers/char/isicom.c | 1610 - include/linux/isicom.h |8 2 files changed, 817 insertions(+), 801 deletions(-) Here it is (about 65 KiB):

[PATCH rc4-mm1] drivers/char/isicom.c old api rewritten

2005-08-01 Thread Jiri Slaby
Hello. Could you send me critics and bugs? Could somebody test it (but NOT now)? Thanks. drivers/char/isicom.c | 1610 - include/linux/isicom.h |8 2 files changed, 817 insertions(+), 801 deletions(-) Here it is (about 65 KiB):