Re: [PATCH repost 12/16] parisc/uaccess: fix sparse errors

2014-12-31 Thread James Bottomley
On Wed, 2014-12-31 at 20:38 +0200, Michael S. Tsirkin wrote: > On Wed, Dec 31, 2014 at 09:17:20AM -0800, James Bottomley wrote: [...] > > OK, parisc developers still being dense, but this does look like an > > abuse of the bitwise type. > > To give you another example: > > __le16 __user

Re: [PATCH repost 12/16] parisc/uaccess: fix sparse errors

2014-12-31 Thread Michael S. Tsirkin
On Wed, Dec 31, 2014 at 09:17:20AM -0800, James Bottomley wrote: > On Sat, 2014-12-27 at 18:14 +0200, Michael S. Tsirkin wrote: > > On Thu, Dec 25, 2014 at 11:37:45PM +0100, Helge Deller wrote: > > > Hi Michael, > > > > > > On 12/25/2014 10:29 AM, Michael S. Tsirkin wrote: > > > >virtio wants to

Re: [PATCH repost 12/16] parisc/uaccess: fix sparse errors

2014-12-31 Thread James Bottomley
On Sat, 2014-12-27 at 18:14 +0200, Michael S. Tsirkin wrote: > On Thu, Dec 25, 2014 at 11:37:45PM +0100, Helge Deller wrote: > > Hi Michael, > > > > On 12/25/2014 10:29 AM, Michael S. Tsirkin wrote: > > >virtio wants to read bitwise types from userspace using get_user. At the > > > > I don't

Re: [PATCH repost 12/16] parisc/uaccess: fix sparse errors

2014-12-31 Thread James Bottomley
On Sat, 2014-12-27 at 18:14 +0200, Michael S. Tsirkin wrote: On Thu, Dec 25, 2014 at 11:37:45PM +0100, Helge Deller wrote: Hi Michael, On 12/25/2014 10:29 AM, Michael S. Tsirkin wrote: virtio wants to read bitwise types from userspace using get_user. At the I don't know the virtio

Re: [PATCH repost 12/16] parisc/uaccess: fix sparse errors

2014-12-31 Thread Michael S. Tsirkin
On Wed, Dec 31, 2014 at 09:17:20AM -0800, James Bottomley wrote: On Sat, 2014-12-27 at 18:14 +0200, Michael S. Tsirkin wrote: On Thu, Dec 25, 2014 at 11:37:45PM +0100, Helge Deller wrote: Hi Michael, On 12/25/2014 10:29 AM, Michael S. Tsirkin wrote: virtio wants to read bitwise

Re: [PATCH repost 12/16] parisc/uaccess: fix sparse errors

2014-12-31 Thread James Bottomley
On Wed, 2014-12-31 at 20:38 +0200, Michael S. Tsirkin wrote: On Wed, Dec 31, 2014 at 09:17:20AM -0800, James Bottomley wrote: [...] OK, parisc developers still being dense, but this does look like an abuse of the bitwise type. To give you another example: __le16 __user *p;

Re: [PATCH repost 12/16] parisc/uaccess: fix sparse errors

2014-12-27 Thread Michael S. Tsirkin
On Thu, Dec 25, 2014 at 11:37:45PM +0100, Helge Deller wrote: > Hi Michael, > > On 12/25/2014 10:29 AM, Michael S. Tsirkin wrote: > >virtio wants to read bitwise types from userspace using get_user. At the > > I don't know the virtio code much yet, but does it makes sense to read > bitwise

Re: [PATCH repost 12/16] parisc/uaccess: fix sparse errors

2014-12-27 Thread Michael S. Tsirkin
On Thu, Dec 25, 2014 at 11:37:45PM +0100, Helge Deller wrote: Hi Michael, On 12/25/2014 10:29 AM, Michael S. Tsirkin wrote: virtio wants to read bitwise types from userspace using get_user. At the I don't know the virtio code much yet, but does it makes sense to read bitwise types?

Re: [PATCH repost 12/16] parisc/uaccess: fix sparse errors

2014-12-25 Thread Helge Deller
Hi Michael, On 12/25/2014 10:29 AM, Michael S. Tsirkin wrote: virtio wants to read bitwise types from userspace using get_user. At the I don't know the virtio code much yet, but does it makes sense to read bitwise types? Will virtio then get possible troubles because of endianess correct as

[PATCH repost 12/16] parisc/uaccess: fix sparse errors

2014-12-25 Thread Michael S. Tsirkin
virtio wants to read bitwise types from userspace using get_user. At the moment this triggers sparse errors, since the value is passed through an integer. Fix that up using __force. Signed-off-by: Michael S. Tsirkin --- arch/parisc/include/asm/uaccess.h | 2 +- 1 file changed, 1 insertion(+),

[PATCH repost 12/16] parisc/uaccess: fix sparse errors

2014-12-25 Thread Michael S. Tsirkin
virtio wants to read bitwise types from userspace using get_user. At the moment this triggers sparse errors, since the value is passed through an integer. Fix that up using __force. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- arch/parisc/include/asm/uaccess.h | 2 +- 1 file changed,

Re: [PATCH repost 12/16] parisc/uaccess: fix sparse errors

2014-12-25 Thread Helge Deller
Hi Michael, On 12/25/2014 10:29 AM, Michael S. Tsirkin wrote: virtio wants to read bitwise types from userspace using get_user. At the I don't know the virtio code much yet, but does it makes sense to read bitwise types? Will virtio then get possible troubles because of endianess correct as