Re: [PATCH resend] fs/proc: Move kfree outside pde_unload_lock

2013-04-08 Thread Al Viro
On Mon, Apr 08, 2013 at 03:52:08PM -0500, Nathan Zimmer wrote: > Further digging seems to indicate 9984d7394618df9, the one right > after the commit I previously identified. > Not sure what I did wrong with my bisect to put it off by one. Ugh... Can't reproduce here ;-/ Could you give more

Re: [PATCH resend] fs/proc: Move kfree outside pde_unload_lock

2013-04-08 Thread Nathan Zimmer
On 04/08/2013 10:58 AM, Al Viro wrote: On Mon, Apr 08, 2013 at 10:34:07AM -0500, Nathan Zimmer wrote: On 04/05/2013 04:00 PM, Al Viro wrote: On Fri, Apr 05, 2013 at 03:56:17PM -0500, Nathan Zimmer wrote: That didn't produce anything. I'll run some bisections over the weekend and see what I

Re: [PATCH resend] fs/proc: Move kfree outside pde_unload_lock

2013-04-08 Thread Nathan Zimmer
On 04/08/2013 10:58 AM, Al Viro wrote: On Mon, Apr 08, 2013 at 10:34:07AM -0500, Nathan Zimmer wrote: On 04/05/2013 04:00 PM, Al Viro wrote: On Fri, Apr 05, 2013 at 03:56:17PM -0500, Nathan Zimmer wrote: That didn't produce anything. I'll run some bisections over the weekend and see what I

Re: [PATCH resend] fs/proc: Move kfree outside pde_unload_lock

2013-04-08 Thread Al Viro
On Mon, Apr 08, 2013 at 10:34:07AM -0500, Nathan Zimmer wrote: > On 04/05/2013 04:00 PM, Al Viro wrote: > >On Fri, Apr 05, 2013 at 03:56:17PM -0500, Nathan Zimmer wrote: > > > >>That didn't produce anything. I'll run some bisections over the > >>weekend and see what I can sort out. > >*Ugh* > > >

Re: [PATCH resend] fs/proc: Move kfree outside pde_unload_lock

2013-04-08 Thread Nathan Zimmer
On 04/05/2013 04:00 PM, Al Viro wrote: On Fri, Apr 05, 2013 at 03:56:17PM -0500, Nathan Zimmer wrote: That didn't produce anything. I'll run some bisections over the weekend and see what I can sort out. *Ugh* I'd try to build with DEBUG_KMEMLEAK and slapped printks on the entry and exit

Re: [PATCH resend] fs/proc: Move kfree outside pde_unload_lock

2013-04-08 Thread Nathan Zimmer
On 04/05/2013 04:00 PM, Al Viro wrote: On Fri, Apr 05, 2013 at 03:56:17PM -0500, Nathan Zimmer wrote: That didn't produce anything. I'll run some bisections over the weekend and see what I can sort out. *Ugh* I'd try to build with DEBUG_KMEMLEAK and slapped printks on the entry and exit

Re: [PATCH resend] fs/proc: Move kfree outside pde_unload_lock

2013-04-08 Thread Al Viro
On Mon, Apr 08, 2013 at 10:34:07AM -0500, Nathan Zimmer wrote: On 04/05/2013 04:00 PM, Al Viro wrote: On Fri, Apr 05, 2013 at 03:56:17PM -0500, Nathan Zimmer wrote: That didn't produce anything. I'll run some bisections over the weekend and see what I can sort out. *Ugh* I'd try to

Re: [PATCH resend] fs/proc: Move kfree outside pde_unload_lock

2013-04-08 Thread Nathan Zimmer
On 04/08/2013 10:58 AM, Al Viro wrote: On Mon, Apr 08, 2013 at 10:34:07AM -0500, Nathan Zimmer wrote: On 04/05/2013 04:00 PM, Al Viro wrote: On Fri, Apr 05, 2013 at 03:56:17PM -0500, Nathan Zimmer wrote: That didn't produce anything. I'll run some bisections over the weekend and see what I

Re: [PATCH resend] fs/proc: Move kfree outside pde_unload_lock

2013-04-08 Thread Nathan Zimmer
On 04/08/2013 10:58 AM, Al Viro wrote: On Mon, Apr 08, 2013 at 10:34:07AM -0500, Nathan Zimmer wrote: On 04/05/2013 04:00 PM, Al Viro wrote: On Fri, Apr 05, 2013 at 03:56:17PM -0500, Nathan Zimmer wrote: That didn't produce anything. I'll run some bisections over the weekend and see what I

Re: [PATCH resend] fs/proc: Move kfree outside pde_unload_lock

2013-04-08 Thread Al Viro
On Mon, Apr 08, 2013 at 03:52:08PM -0500, Nathan Zimmer wrote: Further digging seems to indicate 9984d7394618df9, the one right after the commit I previously identified. Not sure what I did wrong with my bisect to put it off by one. Ugh... Can't reproduce here ;-/ Could you give more

Re: [PATCH resend] fs/proc: Move kfree outside pde_unload_lock

2013-04-05 Thread Al Viro
On Fri, Apr 05, 2013 at 03:56:17PM -0500, Nathan Zimmer wrote: > That didn't produce anything. I'll run some bisections over the > weekend and see what I can sort out. *Ugh* I'd try to build with DEBUG_KMEMLEAK and slapped printks on the entry and exit from close_pdeo(). If that doesn't show

Re: [PATCH resend] fs/proc: Move kfree outside pde_unload_lock

2013-04-05 Thread Nathan Zimmer
On 04/05/2013 12:36 PM, Al Viro wrote: On Fri, Apr 05, 2013 at 12:05:26PM -0500, Nathan Zimmer wrote: On 04/04/2013 03:44 PM, Al Viro wrote: On Thu, Apr 04, 2013 at 12:12:05PM -0500, Nathan Zimmer wrote: Ok I am cloning the tree now. It does look like the patches would conflict. I'll run

Re: [PATCH resend] fs/proc: Move kfree outside pde_unload_lock

2013-04-05 Thread Al Viro
On Fri, Apr 05, 2013 at 12:05:26PM -0500, Nathan Zimmer wrote: > On 04/04/2013 03:44 PM, Al Viro wrote: > >On Thu, Apr 04, 2013 at 12:12:05PM -0500, Nathan Zimmer wrote: > > > >>Ok I am cloning the tree now. > >>It does look like the patches would conflict. > >>I'll run some tests and take a

Re: [PATCH resend] fs/proc: Move kfree outside pde_unload_lock

2013-04-05 Thread Nathan Zimmer
On 04/04/2013 03:44 PM, Al Viro wrote: On Thu, Apr 04, 2013 at 12:12:05PM -0500, Nathan Zimmer wrote: Ok I am cloning the tree now. It does look like the patches would conflict. I'll run some tests and take a deeper look. FWIW, I've just pushed there a tentative patch that switches to

Re: [PATCH resend] fs/proc: Move kfree outside pde_unload_lock

2013-04-05 Thread Nathan Zimmer
On 04/04/2013 03:44 PM, Al Viro wrote: On Thu, Apr 04, 2013 at 12:12:05PM -0500, Nathan Zimmer wrote: Ok I am cloning the tree now. It does look like the patches would conflict. I'll run some tests and take a deeper look. FWIW, I've just pushed there a tentative patch that switches to

Re: [PATCH resend] fs/proc: Move kfree outside pde_unload_lock

2013-04-05 Thread Al Viro
On Fri, Apr 05, 2013 at 12:05:26PM -0500, Nathan Zimmer wrote: On 04/04/2013 03:44 PM, Al Viro wrote: On Thu, Apr 04, 2013 at 12:12:05PM -0500, Nathan Zimmer wrote: Ok I am cloning the tree now. It does look like the patches would conflict. I'll run some tests and take a deeper look. FWIW,

Re: [PATCH resend] fs/proc: Move kfree outside pde_unload_lock

2013-04-05 Thread Nathan Zimmer
On 04/05/2013 12:36 PM, Al Viro wrote: On Fri, Apr 05, 2013 at 12:05:26PM -0500, Nathan Zimmer wrote: On 04/04/2013 03:44 PM, Al Viro wrote: On Thu, Apr 04, 2013 at 12:12:05PM -0500, Nathan Zimmer wrote: Ok I am cloning the tree now. It does look like the patches would conflict. I'll run

Re: [PATCH resend] fs/proc: Move kfree outside pde_unload_lock

2013-04-05 Thread Al Viro
On Fri, Apr 05, 2013 at 03:56:17PM -0500, Nathan Zimmer wrote: That didn't produce anything. I'll run some bisections over the weekend and see what I can sort out. *Ugh* I'd try to build with DEBUG_KMEMLEAK and slapped printks on the entry and exit from close_pdeo(). If that doesn't show

Re: [PATCH resend] fs/proc: Move kfree outside pde_unload_lock

2013-04-04 Thread Al Viro
On Thu, Apr 04, 2013 at 12:12:05PM -0500, Nathan Zimmer wrote: > Ok I am cloning the tree now. > It does look like the patches would conflict. > I'll run some tests and take a deeper look. FWIW, I've just pushed there a tentative patch that switches to hopefully saner locking (head should be at

Re: [PATCH resend] fs/proc: Move kfree outside pde_unload_lock

2013-04-04 Thread Nathan Zimmer
On 04/04/2013 11:11 AM, Al Viro wrote: On Thu, Apr 04, 2013 at 10:53:39AM -0500, Nathan Zimmer wrote: This moves a kfree outside a spinlock to help scaling on larger (512 core) systems. This should be some relief until we can move the section to use the rcu. Umm... That'll get wrecked as

Re: [PATCH resend] fs/proc: Move kfree outside pde_unload_lock

2013-04-04 Thread Al Viro
On Thu, Apr 04, 2013 at 10:53:39AM -0500, Nathan Zimmer wrote: > This moves a kfree outside a spinlock to help scaling on larger (512 core) > systems. This should be some relief until we can move the section to use > the rcu. Umm... That'll get wrecked as soon as fixes from #experimental go in;

[PATCH resend] fs/proc: Move kfree outside pde_unload_lock

2013-04-04 Thread Nathan Zimmer
This moves a kfree outside a spinlock to help scaling on larger (512 core) systems. This should be some relief until we can move the section to use the rcu. I ran a simple test which just reads from /proc/cpuinfo. Lower is better, as you can see the worst case scenario is improved.

[PATCH resend] fs/proc: Move kfree outside pde_unload_lock

2013-04-04 Thread Nathan Zimmer
This moves a kfree outside a spinlock to help scaling on larger (512 core) systems. This should be some relief until we can move the section to use the rcu. I ran a simple test which just reads from /proc/cpuinfo. Lower is better, as you can see the worst case scenario is improved.

Re: [PATCH resend] fs/proc: Move kfree outside pde_unload_lock

2013-04-04 Thread Al Viro
On Thu, Apr 04, 2013 at 10:53:39AM -0500, Nathan Zimmer wrote: This moves a kfree outside a spinlock to help scaling on larger (512 core) systems. This should be some relief until we can move the section to use the rcu. Umm... That'll get wrecked as soon as fixes from #experimental go in;

Re: [PATCH resend] fs/proc: Move kfree outside pde_unload_lock

2013-04-04 Thread Nathan Zimmer
On 04/04/2013 11:11 AM, Al Viro wrote: On Thu, Apr 04, 2013 at 10:53:39AM -0500, Nathan Zimmer wrote: This moves a kfree outside a spinlock to help scaling on larger (512 core) systems. This should be some relief until we can move the section to use the rcu. Umm... That'll get wrecked as

Re: [PATCH resend] fs/proc: Move kfree outside pde_unload_lock

2013-04-04 Thread Al Viro
On Thu, Apr 04, 2013 at 12:12:05PM -0500, Nathan Zimmer wrote: Ok I am cloning the tree now. It does look like the patches would conflict. I'll run some tests and take a deeper look. FWIW, I've just pushed there a tentative patch that switches to hopefully saner locking (head should be at