Re: [PATCH resend] introduce I_SYNC

2007-06-01 Thread Jörn Engel
On Thu, 31 May 2007 15:46:48 -0700, Andrew Morton wrote: > > > > I_LOCK was used for several unrelated purposes, which caused deadlock > > situations in certain filesystems as a side effect. One of the purposes > > now uses the new I_SYNC bit. > > Do we know what those deadlocks were? It's a bi

Re: [PATCH resend] introduce I_SYNC

2007-06-01 Thread Jörn Engel
On Fri, 1 June 2007 09:59:17 +0100, Anton Altaparmakov wrote: > > I agree that your patch is a good idea. I reviewed the latest > incarnation and it makes sense to me. And your comment concerning Thanks. > the flags is a very welcome addition. Probably ought to find its way > into Docum

Re: [PATCH resend] introduce I_SYNC

2007-06-01 Thread Anton Altaparmakov
Hi, On 16 May 2007, at 18:01, Jörn Engel wrote: Patches fixes a deadlock problem well enough for LogFS to survive. The problem itself is generic and seems to be ancient. Shaggy has code in JFS from about 2.4.20 that seems to work around the deadlock. Dave Chinner indicated that this could c

Re: [PATCH resend] introduce I_SYNC

2007-05-31 Thread Andrew Morton
On Thu, 31 May 2007 16:25:35 +0200 Jörn Engel <[EMAIL PROTECTED]> wrote: > On Wed, 16 May 2007 10:15:35 -0700, Andrew Morton wrote: > > > > If we're going to do this then please let's get some exhaustive commentary > > in there so that others have a chance of understanding these flags without > >

Re: [PATCH resend] introduce I_SYNC

2007-05-31 Thread Dave Kleikamp
On Thu, 2007-05-31 at 16:25 +0200, Jörn Engel wrote: > --- linux-2.6.21logfs/fs/jfs/jfs_txnmgr.c~I_LOCK2007-05-07 > 10:28:55.0 +0200 > +++ linux-2.6.21logfs/fs/jfs/jfs_txnmgr.c 2007-05-29 > 13:10:32.0 +0200 > @@ -1286,7 +1286,14 @@ int txCommit(tid_t tid, /* >

Re: [PATCH resend] introduce I_SYNC

2007-05-31 Thread Jörn Engel
On Wed, 16 May 2007 10:15:35 -0700, Andrew Morton wrote: > > If we're going to do this then please let's get some exhaustive commentary > in there so that others have a chance of understanding these flags without > having to do the amount of reverse-engineering which you've been put through. Done.

Re: [PATCH resend] introduce I_SYNC

2007-05-16 Thread Jörn Engel
On Wed, 16 May 2007 10:15:35 -0700, Andrew Morton wrote: > On Wed, 16 May 2007 19:01:14 +0200 Jörn Engel <[EMAIL PROTECTED]> wrote: > > > This patch introduces a new flag, I_SYNC and seperates out all sync() > > users of I_LOCK to use the new flag instead. > > gack, you like sticking your head in

Re: [PATCH resend] introduce I_SYNC

2007-05-16 Thread Andrew Morton
On Wed, 16 May 2007 19:01:14 +0200 Jörn Engel <[EMAIL PROTECTED]> wrote: > This patch introduces a new flag, I_SYNC and seperates out all sync() > users of I_LOCK to use the new flag instead. gack, you like sticking your head in dark and dusty holes. If we're going to do this then please let's g

[PATCH resend] introduce I_SYNC

2007-05-16 Thread Jörn Engel
While others are busy coming up with new silly names, here is something substantial to worry about. Patches fixes a deadlock problem well enough for LogFS to survive. The problem itself is generic and seems to be ancient. Shaggy has code in JFS from about 2.4.20 that seems to work around the dea