Re: [PATCH resend] serial_core: Fix pm imbalance on unbind

2014-03-27 Thread Geert Uytterhoeven
On Fri, Mar 21, 2014 at 2:06 PM, Peter Hurley wrote: >> When a serial port is closed, uart_close() takes care of shutting down the >> hardware, and powering it down. >> >> When a serial port is unbound while in use, uart_close() bypasses all of >> this, as this is supposed to be done through uart_

Re: [PATCH resend] serial_core: Fix pm imbalance on unbind

2014-03-27 Thread Geert Uytterhoeven
On Fri, Mar 21, 2014 at 2:06 PM, Peter Hurley wrote: >> When a serial port is closed, uart_close() takes care of shutting down the >> hardware, and powering it down. >> >> When a serial port is unbound while in use, uart_close() bypasses all of >> this, as this is supposed to be done through uart_

Re: [PATCH resend] serial_core: Fix pm imbalance on unbind

2014-03-21 Thread Peter Hurley
Hi Geert, On 03/21/2014 09:23 AM, Geert Uytterhoeven wrote: Hi Peter, On Fri, Mar 21, 2014 at 2:06 PM, Peter Hurley wrote: @@ -2681,10 +2683,12 @@ int uart_remove_one_port(struct uart_driver *drv, struct uart_port *uport) } /* -* If the port is used as a console, un

Re: [PATCH resend] serial_core: Fix pm imbalance on unbind

2014-03-21 Thread Geert Uytterhoeven
Hi Peter, On Fri, Mar 21, 2014 at 2:06 PM, Peter Hurley wrote: >> @@ -2681,10 +2683,12 @@ int uart_remove_one_port(struct uart_driver *drv, >> struct uart_port *uport) >> } >> >> /* >> -* If the port is used as a console, unregister it >> +* If the port is used as

Re: [PATCH resend] serial_core: Fix pm imbalance on unbind

2014-03-21 Thread Peter Hurley
On 03/21/2014 05:08 AM, Geert Uytterhoeven wrote: From: Geert Uytterhoeven When a serial port is closed, uart_close() takes care of shutting down the hardware, and powering it down. When a serial port is unbound while in use, uart_close() bypasses all of this, as this is supposed to be done th

[PATCH resend] serial_core: Fix pm imbalance on unbind

2014-03-21 Thread Geert Uytterhoeven
From: Geert Uytterhoeven When a serial port is closed, uart_close() takes care of shutting down the hardware, and powering it down. When a serial port is unbound while in use, uart_close() bypasses all of this, as this is supposed to be done through uart_hangup() (invoked via tty_vhangup() in ua