Re: [PATCH resend 3/3] mm: fix LRU balancing effect of new transparent huge pages

2020-05-27 Thread Shakeel Butt
On Wed, May 27, 2020 at 1:46 PM Andrew Morton wrote: > > On Wed, 27 May 2020 15:41:48 -0400 Johannes Weiner wrote: > > > On Wed, May 27, 2020 at 11:29:58AM -0700, Shakeel Butt wrote: > > > From: Johannes Weiner > > > > > > Currently, THP are counted as single pages until they are split right > >

Re: [PATCH resend 3/3] mm: fix LRU balancing effect of new transparent huge pages

2020-05-27 Thread Andrew Morton
On Wed, 27 May 2020 15:41:48 -0400 Johannes Weiner wrote: > On Wed, May 27, 2020 at 11:29:58AM -0700, Shakeel Butt wrote: > > From: Johannes Weiner > > > > Currently, THP are counted as single pages until they are split right > > before being swapped out. However, at that point the VM is alread

Re: [PATCH resend 3/3] mm: fix LRU balancing effect of new transparent huge pages

2020-05-27 Thread Shakeel Butt
On Wed, May 27, 2020 at 12:42 PM Johannes Weiner wrote: > > On Wed, May 27, 2020 at 11:29:58AM -0700, Shakeel Butt wrote: > > From: Johannes Weiner > > > > Currently, THP are counted as single pages until they are split right > > before being swapped out. However, at that point the VM is already

Re: [PATCH resend 3/3] mm: fix LRU balancing effect of new transparent huge pages

2020-05-27 Thread Johannes Weiner
On Wed, May 27, 2020 at 11:29:58AM -0700, Shakeel Butt wrote: > From: Johannes Weiner > > Currently, THP are counted as single pages until they are split right > before being swapped out. However, at that point the VM is already in > the middle of reclaim, and adjusting the LRU balance then is us

[PATCH resend 3/3] mm: fix LRU balancing effect of new transparent huge pages

2020-05-27 Thread Shakeel Butt
From: Johannes Weiner Currently, THP are counted as single pages until they are split right before being swapped out. However, at that point the VM is already in the middle of reclaim, and adjusting the LRU balance then is useless. Always account THP by the number of basepages, and remove the fi