Re: [PATCH retry] return hidden bug and unlock bugs

2007-10-22 Thread Roel Kluin
Roel Kluin wrote: > This patches shouldn't alter behavior when CONFIG_BUG is disabled. It is meant > as a replacement for the previous patches. > > Concerning the patch changing fs/buffer.c, I am still wondering whether > "page_cache_release(page)" should be placed before or after the BUG(). ...

[PATCH retry] return hidden bug and unlock bugs

2007-10-22 Thread Roel Kluin
This patches shouldn't alter behavior when CONFIG_BUG is disabled. It is meant as a replacement for the previous patches. Concerning the patch changing fs/buffer.c, I am still wondering whether "page_cache_release(page)" should be placed before or after the BUG(). -- Unlock before BUG(), but

[PATCH retry] return hidden bug and unlock bugs

2007-10-22 Thread Roel Kluin
This patches shouldn't alter behavior when CONFIG_BUG is disabled. It is meant as a replacement for the previous patches. Concerning the patch changing fs/buffer.c, I am still wondering whether page_cache_release(page) should be placed before or after the BUG(). -- Unlock before BUG(), but

Re: [PATCH retry] return hidden bug and unlock bugs

2007-10-22 Thread Roel Kluin
Roel Kluin wrote: This patches shouldn't alter behavior when CONFIG_BUG is disabled. It is meant as a replacement for the previous patches. Concerning the patch changing fs/buffer.c, I am still wondering whether page_cache_release(page) should be placed before or after the BUG(). ... @@