Re: [PATCH review 2/6] userns: Allow any uid or gid mappings that don't overlap.

2013-01-28 Thread Aristeu Rozanski
On Mon, Jan 28, 2013 at 06:41:39PM +0400, Lord Glauber Costa of Sealand wrote: > Hello Mr. Someone. > > On 01/28/2013 06:28 PM, Aristeu Rozanski wrote: > > On Fri, Jan 25, 2013 at 06:21:00PM -0800, Eric W. Biederman wrote: > >> When I initially wrote the code for /proc//uid_map. I was lazy > >> a

Re: [PATCH review 2/6] userns: Allow any uid or gid mappings that don't overlap.

2013-01-28 Thread Lord Glauber Costa of Sealand
Hello Mr. Someone. On 01/28/2013 06:28 PM, Aristeu Rozanski wrote: > On Fri, Jan 25, 2013 at 06:21:00PM -0800, Eric W. Biederman wrote: >> When I initially wrote the code for /proc//uid_map. I was lazy >> and avoided duplicate mappings by the simple expedient of ensuring the >> first number in a

Re: [PATCH review 2/6] userns: Allow any uid or gid mappings that don't overlap.

2013-01-28 Thread Aristeu Rozanski
On Fri, Jan 25, 2013 at 06:21:00PM -0800, Eric W. Biederman wrote: > When I initially wrote the code for /proc//uid_map. I was lazy > and avoided duplicate mappings by the simple expedient of ensuring the > first number in a new extent was greater than any number in the > previous extent. > > Unf

Re: [PATCH review 2/6] userns: Allow any uid or gid mappings that don't overlap.

2013-01-26 Thread Serge E. Hallyn
Quoting Eric W. Biederman (ebied...@xmission.com): > > When I initially wrote the code for /proc//uid_map. I was lazy > and avoided duplicate mappings by the simple expedient of ensuring the > first number in a new extent was greater than any number in the > previous extent. > > Unfortunately th

[PATCH review 2/6] userns: Allow any uid or gid mappings that don't overlap.

2013-01-25 Thread Eric W. Biederman
When I initially wrote the code for /proc//uid_map. I was lazy and avoided duplicate mappings by the simple expedient of ensuring the first number in a new extent was greater than any number in the previous extent. Unfortunately that precludes a number of valid mappings, and someone noticed and