Re: [PATCH serial v2] sc16is7xx: missing unregister/delete driver on error in sc16is7xx_init()

2019-03-11 Thread Dan Carpenter
On Mon, Mar 11, 2019 at 05:12:03PM +0800, maowenan wrote: > > > On 2019/3/11 15:46, Dan Carpenter wrote: > > On Sat, Mar 09, 2019 at 10:50:37AM +0800, Mao Wenan wrote: > >> Add the missing uart_unregister_driver() and i2c_del_driver() before return > >> from sc16is7xx_init() in the error

Re: [PATCH serial v2] sc16is7xx: missing unregister/delete driver on error in sc16is7xx_init()

2019-03-11 Thread Dan Carpenter
On Sat, Mar 09, 2019 at 10:50:37AM +0800, Mao Wenan wrote: > Add the missing uart_unregister_driver() and i2c_del_driver() before return > from sc16is7xx_init() in the error handling case. > > Reviewed-by: Vladimir Zapolskiy > Signed-off-by: Mao Wenan > --- > v1->v2: fix compile warning if

[PATCH serial v2] sc16is7xx: missing unregister/delete driver on error in sc16is7xx_init()

2019-03-08 Thread Mao Wenan
Add the missing uart_unregister_driver() and i2c_del_driver() before return from sc16is7xx_init() in the error handling case. Reviewed-by: Vladimir Zapolskiy Signed-off-by: Mao Wenan --- v1->v2: fix compile warning if CONFIG_SERIAL_SC16IS7XX_SPI is not exist. drivers/tty/serial/sc16is7xx.c |