Re: [PATCH take #5] [libata] libata driver for bf548 on chip ATAPI controller.

2007-08-16 Thread Bryan Wu
On Thu, 2007-08-16 at 14:56 -0400, Jeff Garzik wrote: > Mike Frysinger wrote: > > On 8/16/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: > >> Mike Frysinger wrote: > >>> On 8/16/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: > Sonic Zhang wrote: > > +static void bfin_set_piomode(struct ata_port *a

Re: [PATCH take #5] [libata] libata driver for bf548 on chip ATAPI controller.

2007-08-16 Thread Jeff Garzik
Mike Frysinger wrote: On 8/16/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: Mike Frysinger wrote: On 8/16/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: Sonic Zhang wrote: +static void bfin_set_piomode(struct ata_port *ap, struct ata_device *adev) +{ + int mode = adev->pio_mode - XFER_PIO_0; +

Re: [PATCH take #5] [libata] libata driver for bf548 on chip ATAPI controller.

2007-08-16 Thread Mike Frysinger
On 8/16/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: > Mike Frysinger wrote: > > On 8/16/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: > >> Sonic Zhang wrote: > >>> +static void bfin_set_piomode(struct ata_port *ap, struct ata_device > >>> *adev) > >>> +{ > >>> + int mode = adev->pio_mode - XFER_PI

Re: [PATCH take #5] [libata] libata driver for bf548 on chip ATAPI controller.

2007-08-16 Thread Jeff Garzik
Mike Frysinger wrote: On 8/16/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: Sonic Zhang wrote: +static void bfin_set_piomode(struct ata_port *ap, struct ata_device *adev) +{ + int mode = adev->pio_mode - XFER_PIO_0; + unsigned long base = (unsigned long)ap->ioaddr.ctl_addr; (added Bryan

Re: [PATCH take #5] [libata] libata driver for bf548 on chip ATAPI controller.

2007-08-16 Thread Mike Frysinger
On 8/16/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: > Sonic Zhang wrote: > > +static void bfin_set_piomode(struct ata_port *ap, struct ata_device *adev) > > +{ > > + int mode = adev->pio_mode - XFER_PIO_0; > > + unsigned long base = (unsigned long)ap->ioaddr.ctl_addr; > > > (added Bryan Wu t

Re: [PATCH take #5] [libata] libata driver for bf548 on chip ATAPI controller.

2007-08-16 Thread Jeff Garzik
Sonic Zhang wrote: Update: 1. Condition branch code instead of while loop from Alan Cox. 2. Condtinue in PIO mode after failing to request DMA. Signed-off-by: Sonic Zhang <[EMAIL PROTECTED]> --- drivers/ata/Kconfig | 28 + drivers/ata/Makefile |1 drivers/ata/pata_bf54x.c | 1581

Re: [PATCH take #5] [libata] libata driver for bf548 on chip ATAPI controller.

2007-08-15 Thread Alan Cox
On Wed, 15 Aug 2007 17:14:15 +0800 Sonic Zhang <[EMAIL PROTECTED]> wrote: > Update: > 1. Condition branch code instead of while loop from Alan Cox. > 2. Condtinue in PIO mode after failing to request DMA. > > Signed-off-by: Sonic Zhang <[EMAIL PROTECTED]> Acked-by: Alan Cox <[EMAIL PROTECTED]>

[PATCH take #5] [libata] libata driver for bf548 on chip ATAPI controller.

2007-08-15 Thread Sonic Zhang
Update: 1. Condition branch code instead of while loop from Alan Cox. 2. Condtinue in PIO mode after failing to request DMA. Signed-off-by: Sonic Zhang <[EMAIL PROTECTED]> --- drivers/ata/Kconfig | 28 + drivers/ata/Makefile |1 drivers/ata/pata_bf54x.c | 1581