Re: [PATCH tip/core/rcu 3/9] drivers/md: Use rcu_dereference() for accessing rcu pointer

2014-11-23 Thread Eric Dumazet
On Sun, 2014-11-23 at 07:21 -0500, Pranith Kumar wrote: > I am not sure we should be taking rcu_read_lock() there as I am not > sure how long that critical section might last. Can someone who is > more familiar with the code take a look? > > I will try to look for a solution too in the mean

Re: [PATCH tip/core/rcu 3/9] drivers/md: Use rcu_dereference() for accessing rcu pointer

2014-11-23 Thread Pranith Kumar
On Fri, Nov 21, 2014 at 9:58 AM, Kirill A. Shutemov wrote: > On Fri, Nov 21, 2014 at 09:30:36AM -0500, Pranith Kumar wrote: >> On 11/21/2014 08:31 AM, Kirill A. Shutemov wrote: >> > On Tue, Oct 28, 2014 at 03:09:56PM -0700, Paul E. McKenney wrote: >> >> From: Pranith Kumar >> >> >> >> Got Paul's

Re: [PATCH tip/core/rcu 3/9] drivers/md: Use rcu_dereference() for accessing rcu pointer

2014-11-23 Thread Pranith Kumar
On Fri, Nov 21, 2014 at 9:58 AM, Kirill A. Shutemov kir...@shutemov.name wrote: On Fri, Nov 21, 2014 at 09:30:36AM -0500, Pranith Kumar wrote: On 11/21/2014 08:31 AM, Kirill A. Shutemov wrote: On Tue, Oct 28, 2014 at 03:09:56PM -0700, Paul E. McKenney wrote: From: Pranith Kumar

Re: [PATCH tip/core/rcu 3/9] drivers/md: Use rcu_dereference() for accessing rcu pointer

2014-11-23 Thread Eric Dumazet
On Sun, 2014-11-23 at 07:21 -0500, Pranith Kumar wrote: I am not sure we should be taking rcu_read_lock() there as I am not sure how long that critical section might last. Can someone who is more familiar with the code take a look? I will try to look for a solution too in the mean time. I

Re: [PATCH tip/core/rcu 3/9] drivers/md: Use rcu_dereference() for accessing rcu pointer

2014-11-21 Thread Kirill A. Shutemov
On Fri, Nov 21, 2014 at 09:30:36AM -0500, Pranith Kumar wrote: > On 11/21/2014 08:31 AM, Kirill A. Shutemov wrote: > > On Tue, Oct 28, 2014 at 03:09:56PM -0700, Paul E. McKenney wrote: > >> From: Pranith Kumar > >> > >> Got Paul's email wrong the first time. > >> > >> The map field in 'struct

Re: [PATCH tip/core/rcu 3/9] drivers/md: Use rcu_dereference() for accessing rcu pointer

2014-11-21 Thread Pranith Kumar
On 11/21/2014 08:31 AM, Kirill A. Shutemov wrote: > On Tue, Oct 28, 2014 at 03:09:56PM -0700, Paul E. McKenney wrote: >> From: Pranith Kumar >> >> Got Paul's email wrong the first time. >> >> The map field in 'struct mapped_device' is an rcu pointer. Use >> rcu_dereference() >> while accessing

Re: [PATCH tip/core/rcu 3/9] drivers/md: Use rcu_dereference() for accessing rcu pointer

2014-11-21 Thread Kirill A. Shutemov
On Tue, Oct 28, 2014 at 03:09:56PM -0700, Paul E. McKenney wrote: > From: Pranith Kumar > > Got Paul's email wrong the first time. > > The map field in 'struct mapped_device' is an rcu pointer. Use > rcu_dereference() > while accessing it. > > Signed-off-by: Pranith Kumar > Signed-off-by:

Re: [PATCH tip/core/rcu 3/9] drivers/md: Use rcu_dereference() for accessing rcu pointer

2014-11-21 Thread Kirill A. Shutemov
On Tue, Oct 28, 2014 at 03:09:56PM -0700, Paul E. McKenney wrote: From: Pranith Kumar bobby.pr...@gmail.com Got Paul's email wrong the first time. The map field in 'struct mapped_device' is an rcu pointer. Use rcu_dereference() while accessing it. Signed-off-by: Pranith Kumar

Re: [PATCH tip/core/rcu 3/9] drivers/md: Use rcu_dereference() for accessing rcu pointer

2014-11-21 Thread Pranith Kumar
On 11/21/2014 08:31 AM, Kirill A. Shutemov wrote: On Tue, Oct 28, 2014 at 03:09:56PM -0700, Paul E. McKenney wrote: From: Pranith Kumar bobby.pr...@gmail.com Got Paul's email wrong the first time. The map field in 'struct mapped_device' is an rcu pointer. Use rcu_dereference() while

Re: [PATCH tip/core/rcu 3/9] drivers/md: Use rcu_dereference() for accessing rcu pointer

2014-11-21 Thread Kirill A. Shutemov
On Fri, Nov 21, 2014 at 09:30:36AM -0500, Pranith Kumar wrote: On 11/21/2014 08:31 AM, Kirill A. Shutemov wrote: On Tue, Oct 28, 2014 at 03:09:56PM -0700, Paul E. McKenney wrote: From: Pranith Kumar bobby.pr...@gmail.com Got Paul's email wrong the first time. The map field in 'struct

[PATCH tip/core/rcu 3/9] drivers/md: Use rcu_dereference() for accessing rcu pointer

2014-10-28 Thread Paul E. McKenney
From: Pranith Kumar Got Paul's email wrong the first time. The map field in 'struct mapped_device' is an rcu pointer. Use rcu_dereference() while accessing it. Signed-off-by: Pranith Kumar Signed-off-by: Paul E. McKenney --- drivers/md/dm.c | 8 1 file changed, 4 insertions(+), 4

[PATCH tip/core/rcu 3/9] drivers/md: Use rcu_dereference() for accessing rcu pointer

2014-10-28 Thread Paul E. McKenney
From: Pranith Kumar bobby.pr...@gmail.com Got Paul's email wrong the first time. The map field in 'struct mapped_device' is an rcu pointer. Use rcu_dereference() while accessing it. Signed-off-by: Pranith Kumar bobby.pr...@gmail.com Signed-off-by: Paul E. McKenney paul...@linux.vnet.ibm.com ---