Re: [PATCH tip/core/rcu 6/9] rcu: Upgrade sync_exp_work_done() to smp_mb()

2019-06-13 Thread Paul E. McKenney
On Thu, Jun 06, 2019 at 09:48:49AM +0200, Peter Zijlstra wrote: > On Thu, May 30, 2019 at 08:00:12AM -0700, Paul E. McKenney wrote: > > The sync_exp_work_done() function uses smp_mb__before_atomic(), but > > there is no obvious atomic in the ensuing code. The ordering is > > absolutely required fo

Re: [PATCH tip/core/rcu 6/9] rcu: Upgrade sync_exp_work_done() to smp_mb()

2019-06-06 Thread Peter Zijlstra
On Thu, May 30, 2019 at 08:00:12AM -0700, Paul E. McKenney wrote: > The sync_exp_work_done() function uses smp_mb__before_atomic(), but > there is no obvious atomic in the ensuing code. The ordering is > absolutely required for grace periods to work correctly, so this > commit upgrades the smp_mb_

[PATCH tip/core/rcu 6/9] rcu: Upgrade sync_exp_work_done() to smp_mb()

2019-05-30 Thread Paul E. McKenney
The sync_exp_work_done() function uses smp_mb__before_atomic(), but there is no obvious atomic in the ensuing code. The ordering is absolutely required for grace periods to work correctly, so this commit upgrades the smp_mb__before_atomic() to smp_mb(). Reported-by: Andrea Parri Signed-off-by: P