Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-27 Thread Serge E. Hallyn
Quoting James Morris ([EMAIL PROTECTED]): > On Wed, 27 Jun 2007, Serge E. Hallyn wrote: > > > Patch tests fine for me for expected capability behavior with lsm=n, > > lsm=y, lsm=y+capability=y, lsm=y+selinux=y, and lsm=y+caps=y+selinux=y. > > > > So while I'm opposed to the patch, it appears to

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-27 Thread James Morris
On Wed, 27 Jun 2007, Serge E. Hallyn wrote: > Patch tests fine for me for expected capability behavior with lsm=n, > lsm=y, lsm=y+capability=y, lsm=y+selinux=y, and lsm=y+caps=y+selinux=y. > > So while I'm opposed to the patch, it appears to be safe. I've also tested a bunch of scenarios:

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-27 Thread Serge E. Hallyn
Quoting Serge E. Hallyn ([EMAIL PROTECTED]): > Quoting James Morris ([EMAIL PROTECTED]): > > On Wed, 27 Jun 2007, Serge E. Hallyn wrote: > > > > > Quoting Kyle Moffett ([EMAIL PROTECTED]): > > > > This whole discussion boils down to 2 points: > > > > > > Yes it can, but not the two you list. > >

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-27 Thread Serge E. Hallyn
Quoting James Morris ([EMAIL PROTECTED]): > On Wed, 27 Jun 2007, Serge E. Hallyn wrote: > > > Quoting Kyle Moffett ([EMAIL PROTECTED]): > > > This whole discussion boils down to 2 points: > > > > Yes it can, but not the two you list. > > > > > 1) As currently implemented, no LSM may be safely

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-27 Thread James Morris
On Wed, 27 Jun 2007, Serge E. Hallyn wrote: > Quoting Kyle Moffett ([EMAIL PROTECTED]): > > This whole discussion boils down to 2 points: > > Yes it can, but not the two you list. > > > 1) As currently implemented, no LSM may be safely rmmod-ed > > That's not the rationale for the patch,

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-27 Thread Serge E. Hallyn
Quoting Kyle Moffett ([EMAIL PROTECTED]): > This whole discussion boils down to 2 points: Yes it can, but not the two you list. > 1) As currently implemented, no LSM may be safely rmmod-ed That's not the rationale for the patch, it's just some talking point you picked up. The rationale for

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-27 Thread Serge E. Hallyn
Quoting Kyle Moffett ([EMAIL PROTECTED]): This whole discussion boils down to 2 points: Yes it can, but not the two you list. 1) As currently implemented, no LSM may be safely rmmod-ed That's not the rationale for the patch, it's just some talking point you picked up. The rationale for the

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-27 Thread James Morris
On Wed, 27 Jun 2007, Serge E. Hallyn wrote: Quoting Kyle Moffett ([EMAIL PROTECTED]): This whole discussion boils down to 2 points: Yes it can, but not the two you list. 1) As currently implemented, no LSM may be safely rmmod-ed That's not the rationale for the patch, it's just

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-27 Thread Serge E. Hallyn
Quoting James Morris ([EMAIL PROTECTED]): On Wed, 27 Jun 2007, Serge E. Hallyn wrote: Quoting Kyle Moffett ([EMAIL PROTECTED]): This whole discussion boils down to 2 points: Yes it can, but not the two you list. 1) As currently implemented, no LSM may be safely rmmod-ed

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-27 Thread Serge E. Hallyn
Quoting Serge E. Hallyn ([EMAIL PROTECTED]): Quoting James Morris ([EMAIL PROTECTED]): On Wed, 27 Jun 2007, Serge E. Hallyn wrote: Quoting Kyle Moffett ([EMAIL PROTECTED]): This whole discussion boils down to 2 points: Yes it can, but not the two you list. 1) As

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-27 Thread James Morris
On Wed, 27 Jun 2007, Serge E. Hallyn wrote: Patch tests fine for me for expected capability behavior with lsm=n, lsm=y, lsm=y+capability=y, lsm=y+selinux=y, and lsm=y+caps=y+selinux=y. So while I'm opposed to the patch, it appears to be safe. I've also tested a bunch of scenarios:

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-27 Thread Serge E. Hallyn
Quoting James Morris ([EMAIL PROTECTED]): On Wed, 27 Jun 2007, Serge E. Hallyn wrote: Patch tests fine for me for expected capability behavior with lsm=n, lsm=y, lsm=y+capability=y, lsm=y+selinux=y, and lsm=y+caps=y+selinux=y. So while I'm opposed to the patch, it appears to be safe.

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-26 Thread Chris Wright
* Crispin Cowan ([EMAIL PROTECTED]) wrote: > and simple LSMs that can be > unloaded safely can permit it. there are none, and making the above possible is prohibitively expensive. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-26 Thread Kyle Moffett
On Jun 26, 2007, at 20:57:53, Crispin Cowan wrote: Kyle Moffett wrote: Let's go over the differences between "my fs" and "my LSM", and the similarities between "my VM" and "my LSM": Filesystems don't get hooked from virtually every userspace-initiated operation, whereas both VMs and LSMs

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-26 Thread Crispin Cowan
Kyle Moffett wrote: > Let's go over the differences between "my fs" and "my LSM", and the > similarities between "my VM" and "my LSM": Filesystems don't get > hooked from virtually every userspace-initiated operation, whereas > both VMs and LSMs do. VMs and LSMs attach anonymous state data to a

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-26 Thread Kyle Moffett
On Jun 26, 2007, at 09:47:12, Serge E. Hallyn wrote: Quoting Kyle Moffett ([EMAIL PROTECTED]): On Jun 25, 2007, at 16:37:58, Andreas Gruenbacher wrote: It's useful for some LSMs to be modular, and LSMs which are y/n options won't have any security architecture issues with unloading at all.

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-26 Thread Adrian Bunk
On Tue, Jun 26, 2007 at 10:53:29AM -0500, Serge E. Hallyn wrote: > Quoting Adrian Bunk ([EMAIL PROTECTED]): > > On Tue, Jun 26, 2007 at 09:06:44AM -0500, Serge E. Hallyn wrote: > > > Quoting Adrian Bunk ([EMAIL PROTECTED]): > > > > On Mon, Jun 25, 2007 at 10:57:31PM -0500, Serge E. Hallyn wrote: >

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-26 Thread Serge E. Hallyn
Quoting Greg KH ([EMAIL PROTECTED]): > On Tue, Jun 26, 2007 at 09:06:44AM -0500, Serge E. Hallyn wrote: > > Quoting Adrian Bunk ([EMAIL PROTECTED]): > > > On Mon, Jun 25, 2007 at 10:57:31PM -0500, Serge E. Hallyn wrote: > > > > Quoting James Morris ([EMAIL PROTECTED]): > > > > > On Mon, 25 Jun

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-26 Thread Greg KH
On Tue, Jun 26, 2007 at 09:06:44AM -0500, Serge E. Hallyn wrote: > Quoting Adrian Bunk ([EMAIL PROTECTED]): > > On Mon, Jun 25, 2007 at 10:57:31PM -0500, Serge E. Hallyn wrote: > > > Quoting James Morris ([EMAIL PROTECTED]): > > > > On Mon, 25 Jun 2007, Andreas Gruenbacher wrote: > > > > > > > >

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-26 Thread Serge E. Hallyn
Quoting Adrian Bunk ([EMAIL PROTECTED]): > On Tue, Jun 26, 2007 at 09:06:44AM -0500, Serge E. Hallyn wrote: > > Quoting Adrian Bunk ([EMAIL PROTECTED]): > > > On Mon, Jun 25, 2007 at 10:57:31PM -0500, Serge E. Hallyn wrote: > > > > Quoting James Morris ([EMAIL PROTECTED]): > > > > > On Mon, 25 Jun

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-26 Thread Adrian Bunk
On Tue, Jun 26, 2007 at 09:06:44AM -0500, Serge E. Hallyn wrote: > Quoting Adrian Bunk ([EMAIL PROTECTED]): > > On Mon, Jun 25, 2007 at 10:57:31PM -0500, Serge E. Hallyn wrote: > > > Quoting James Morris ([EMAIL PROTECTED]): > > > > On Mon, 25 Jun 2007, Andreas Gruenbacher wrote: > > > > > > > >

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-26 Thread Serge E. Hallyn
Quoting Adrian Bunk ([EMAIL PROTECTED]): > On Mon, Jun 25, 2007 at 10:57:31PM -0500, Serge E. Hallyn wrote: > > Quoting James Morris ([EMAIL PROTECTED]): > > > On Mon, 25 Jun 2007, Andreas Gruenbacher wrote: > > > > > > > It's useful for some LSMs to be modular, and LSMs which are y/n options >

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-26 Thread Serge E. Hallyn
Quoting Kyle Moffett ([EMAIL PROTECTED]): > On Jun 25, 2007, at 16:37:58, Andreas Gruenbacher wrote: > >On Monday 25 June 2007 06:33, James Morris wrote: > >>Convert LSM into a static interface, as the ability to unload a > >>security module is not required by in-tree users and potentially >

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-26 Thread Adrian Bunk
On Mon, Jun 25, 2007 at 10:57:31PM -0500, Serge E. Hallyn wrote: > Quoting James Morris ([EMAIL PROTECTED]): > > On Mon, 25 Jun 2007, Andreas Gruenbacher wrote: > > > > > It's useful for some LSMs to be modular, and LSMs which are y/n options > > > won't > > > have any security architecture

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-26 Thread Adrian Bunk
On Mon, Jun 25, 2007 at 10:57:31PM -0500, Serge E. Hallyn wrote: Quoting James Morris ([EMAIL PROTECTED]): On Mon, 25 Jun 2007, Andreas Gruenbacher wrote: It's useful for some LSMs to be modular, and LSMs which are y/n options won't have any security architecture issues with

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-26 Thread Serge E. Hallyn
Quoting Kyle Moffett ([EMAIL PROTECTED]): On Jun 25, 2007, at 16:37:58, Andreas Gruenbacher wrote: On Monday 25 June 2007 06:33, James Morris wrote: Convert LSM into a static interface, as the ability to unload a security module is not required by in-tree users and potentially complicates

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-26 Thread Serge E. Hallyn
Quoting Adrian Bunk ([EMAIL PROTECTED]): On Mon, Jun 25, 2007 at 10:57:31PM -0500, Serge E. Hallyn wrote: Quoting James Morris ([EMAIL PROTECTED]): On Mon, 25 Jun 2007, Andreas Gruenbacher wrote: It's useful for some LSMs to be modular, and LSMs which are y/n options won't

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-26 Thread Adrian Bunk
On Tue, Jun 26, 2007 at 09:06:44AM -0500, Serge E. Hallyn wrote: Quoting Adrian Bunk ([EMAIL PROTECTED]): On Mon, Jun 25, 2007 at 10:57:31PM -0500, Serge E. Hallyn wrote: Quoting James Morris ([EMAIL PROTECTED]): On Mon, 25 Jun 2007, Andreas Gruenbacher wrote: It's useful for

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-26 Thread Serge E. Hallyn
Quoting Adrian Bunk ([EMAIL PROTECTED]): On Tue, Jun 26, 2007 at 09:06:44AM -0500, Serge E. Hallyn wrote: Quoting Adrian Bunk ([EMAIL PROTECTED]): On Mon, Jun 25, 2007 at 10:57:31PM -0500, Serge E. Hallyn wrote: Quoting James Morris ([EMAIL PROTECTED]): On Mon, 25 Jun 2007, Andreas

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-26 Thread Greg KH
On Tue, Jun 26, 2007 at 09:06:44AM -0500, Serge E. Hallyn wrote: Quoting Adrian Bunk ([EMAIL PROTECTED]): On Mon, Jun 25, 2007 at 10:57:31PM -0500, Serge E. Hallyn wrote: Quoting James Morris ([EMAIL PROTECTED]): On Mon, 25 Jun 2007, Andreas Gruenbacher wrote: It's useful for

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-26 Thread Serge E. Hallyn
Quoting Greg KH ([EMAIL PROTECTED]): On Tue, Jun 26, 2007 at 09:06:44AM -0500, Serge E. Hallyn wrote: Quoting Adrian Bunk ([EMAIL PROTECTED]): On Mon, Jun 25, 2007 at 10:57:31PM -0500, Serge E. Hallyn wrote: Quoting James Morris ([EMAIL PROTECTED]): On Mon, 25 Jun 2007, Andreas

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-26 Thread Adrian Bunk
On Tue, Jun 26, 2007 at 10:53:29AM -0500, Serge E. Hallyn wrote: Quoting Adrian Bunk ([EMAIL PROTECTED]): On Tue, Jun 26, 2007 at 09:06:44AM -0500, Serge E. Hallyn wrote: Quoting Adrian Bunk ([EMAIL PROTECTED]): On Mon, Jun 25, 2007 at 10:57:31PM -0500, Serge E. Hallyn wrote:

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-26 Thread Kyle Moffett
On Jun 26, 2007, at 09:47:12, Serge E. Hallyn wrote: Quoting Kyle Moffett ([EMAIL PROTECTED]): On Jun 25, 2007, at 16:37:58, Andreas Gruenbacher wrote: It's useful for some LSMs to be modular, and LSMs which are y/n options won't have any security architecture issues with unloading at all.

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-26 Thread Crispin Cowan
Kyle Moffett wrote: Let's go over the differences between my fs and my LSM, and the similarities between my VM and my LSM: Filesystems don't get hooked from virtually every userspace-initiated operation, whereas both VMs and LSMs do. VMs and LSMs attach anonymous state data to a large

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-26 Thread Kyle Moffett
On Jun 26, 2007, at 20:57:53, Crispin Cowan wrote: Kyle Moffett wrote: Let's go over the differences between my fs and my LSM, and the similarities between my VM and my LSM: Filesystems don't get hooked from virtually every userspace-initiated operation, whereas both VMs and LSMs do. VMs

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-26 Thread Chris Wright
* Crispin Cowan ([EMAIL PROTECTED]) wrote: and simple LSMs that can be unloaded safely can permit it. there are none, and making the above possible is prohibitively expensive. - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED]

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-25 Thread Kyle Moffett
Oops, typo: On Jun 26, 2007, at 00:09:24, Kyle Moffett wrote: This sounds suspiciously like "The mere fact that the Linux-2.6-VM cannot be built as a module is a rather weak argument for disabling VFS modules as a whole" Meant to say: "...disabling VM modules as a whole." Cheers, Kyle

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-25 Thread Kyle Moffett
On Jun 25, 2007, at 16:37:58, Andreas Gruenbacher wrote: On Monday 25 June 2007 06:33, James Morris wrote: Convert LSM into a static interface, as the ability to unload a security module is not required by in-tree users and potentially complicates the overall security architecture. It's

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-25 Thread Serge E. Hallyn
Quoting James Morris ([EMAIL PROTECTED]): > On Mon, 25 Jun 2007, Andreas Gruenbacher wrote: > > > It's useful for some LSMs to be modular, and LSMs which are y/n options > > won't > > have any security architecture issues with unloading at all. > > Which LSMs? Upstream, there are SELinux and

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-25 Thread James Morris
On Mon, 25 Jun 2007, Andreas Gruenbacher wrote: > It's useful for some LSMs to be modular, and LSMs which are y/n options won't > have any security architecture issues with unloading at all. Which LSMs? Upstream, there are SELinux and capabilty, and they're not safe as loadable modules. >

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-25 Thread Andreas Gruenbacher
On Monday 25 June 2007 06:33, James Morris wrote: > Convert LSM into a static interface, as the ability to unload a security > module is not required by in-tree users and potentially complicates the > overall security architecture. It's useful for some LSMs to be modular, and LSMs which are y/n

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-25 Thread Stephen Smalley
On Mon, 2007-06-25 at 00:33 -0400, James Morris wrote: > Convert LSM into a static interface, as the ability to unload a security > module is not required by in-tree users and potentially complicates the > overall security architecture. > > Needlessly exported LSM symbols have been unexported,

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-25 Thread Stephen Smalley
On Mon, 2007-06-25 at 00:33 -0400, James Morris wrote: Convert LSM into a static interface, as the ability to unload a security module is not required by in-tree users and potentially complicates the overall security architecture. Needlessly exported LSM symbols have been unexported, to

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-25 Thread Andreas Gruenbacher
On Monday 25 June 2007 06:33, James Morris wrote: Convert LSM into a static interface, as the ability to unload a security module is not required by in-tree users and potentially complicates the overall security architecture. It's useful for some LSMs to be modular, and LSMs which are y/n

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-25 Thread James Morris
On Mon, 25 Jun 2007, Andreas Gruenbacher wrote: It's useful for some LSMs to be modular, and LSMs which are y/n options won't have any security architecture issues with unloading at all. Which LSMs? Upstream, there are SELinux and capabilty, and they're not safe as loadable modules. The

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-25 Thread Serge E. Hallyn
Quoting James Morris ([EMAIL PROTECTED]): On Mon, 25 Jun 2007, Andreas Gruenbacher wrote: It's useful for some LSMs to be modular, and LSMs which are y/n options won't have any security architecture issues with unloading at all. Which LSMs? Upstream, there are SELinux and

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-25 Thread Kyle Moffett
On Jun 25, 2007, at 16:37:58, Andreas Gruenbacher wrote: On Monday 25 June 2007 06:33, James Morris wrote: Convert LSM into a static interface, as the ability to unload a security module is not required by in-tree users and potentially complicates the overall security architecture. It's

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-25 Thread Kyle Moffett
Oops, typo: On Jun 26, 2007, at 00:09:24, Kyle Moffett wrote: This sounds suspiciously like The mere fact that the Linux-2.6-VM cannot be built as a module is a rather weak argument for disabling VFS modules as a whole Meant to say: ...disabling VM modules as a whole. Cheers, Kyle Moffett

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-24 Thread James Morris
On Sun, 24 Jun 2007, Petr Vandrovec wrote: > > -module_param(debug, bool, 0600); > > -MODULE_PARM_DESC(debug, "Debug enabled or not"); > > +static int __init root_plug_debug(char *str) > > +{ > > + debug = simple_strtol(str, NULL, 0); > > + return 1; > > +} > > +__setup("root_plug_debug=",

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-24 Thread Petr Vandrovec
James Morris wrote: Convert LSM into a static interface, as the ability to unload a security module is not required by in-tree users and potentially complicates the overall security architecture. Hello, -module_param(debug, bool, 0600); -MODULE_PARM_DESC(debug, "Debug enabled or not");

[PATCH try #2] security: Convert LSM into a static interface

2007-06-24 Thread James Morris
Convert LSM into a static interface, as the ability to unload a security module is not required by in-tree users and potentially complicates the overall security architecture. Needlessly exported LSM symbols have been unexported, to help reduce API abuse. Parameters for the capability and

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-24 Thread Petr Vandrovec
James Morris wrote: Convert LSM into a static interface, as the ability to unload a security module is not required by in-tree users and potentially complicates the overall security architecture. Hello, -module_param(debug, bool, 0600); -MODULE_PARM_DESC(debug, Debug enabled or not);

[PATCH try #2] security: Convert LSM into a static interface

2007-06-24 Thread James Morris
Convert LSM into a static interface, as the ability to unload a security module is not required by in-tree users and potentially complicates the overall security architecture. Needlessly exported LSM symbols have been unexported, to help reduce API abuse. Parameters for the capability and

Re: [PATCH try #2] security: Convert LSM into a static interface

2007-06-24 Thread James Morris
On Sun, 24 Jun 2007, Petr Vandrovec wrote: -module_param(debug, bool, 0600); -MODULE_PARM_DESC(debug, Debug enabled or not); +static int __init root_plug_debug(char *str) +{ + debug = simple_strtol(str, NULL, 0); + return 1; +} +__setup(root_plug_debug=, root_plug_debug);