Re: [PATCH update] firewire: fix "kobject_add failed for fw* with -EEXIST"

2008-01-28 Thread Stefan Richter
I wrote: > But the interaction with userspace processes opening /dev/fwX while the > respective node is being shut down gave me headaches. I am still not > entirely sure if I got it right in the patch update, i.e. if it is free > from deadlocks. fw_device_shutdown() and fw_device_op_open() can

Re: [PATCH update] firewire: fix "kobject_add failed for fw* with -EEXIST"

2008-01-28 Thread Jarod Wilson
On Sunday 27 January 2008 12:20:40 pm Stefan Richter wrote: > There is a race between shutdown and creation of devices: fw-core may > attempt to add a device with the same name of an already existing > device. http://bugzilla.kernel.org/show_bug.cgi?id=9828 > > Impact of the bug: Happens

Re: [PATCH update] firewire: fix "kobject_add failed for fw* with -EEXIST"

2008-01-28 Thread Jarod Wilson
On Monday 28 January 2008 01:54:14 pm Stefan Richter wrote: > Jarod Wilson wrote: > > We may have another issue there though, as when this happened to me, the > > md layer apparently never noticed (after ~6 hours) that one of the array > > members had disappeared -- not sure if that's firewire's

Re: [PATCH update] firewire: fix "kobject_add failed for fw* with -EEXIST"

2008-01-28 Thread Stefan Richter
Jarod Wilson wrote: > Looks straight-forward enough, and I'll give these a spin shortly and see if > I > can reproduce the situation I was hitting with my raid array... As far as the naming of devices is concerned, the bug and the necessary fix are entirely obvious. But the interaction with

Re: [PATCH update] firewire: fix "kobject_add failed for fw* with -EEXIST"

2008-01-28 Thread Stefan Richter
Jarod Wilson wrote: > We may have another issue there though, as when this happened to me, the md > layer apparently never noticed (after ~6 hours) that one of the array members > had disappeared -- not sure if that's firewire's fault or md's though... This > will presumably avoid this

Re: [PATCH update] firewire: fix "kobject_add failed for fw* with -EEXIST"

2008-01-28 Thread Jarod Wilson
On Sunday 27 January 2008 12:20:40 pm Stefan Richter wrote: > There is a race between shutdown and creation of devices: fw-core may > attempt to add a device with the same name of an already existing > device. http://bugzilla.kernel.org/show_bug.cgi?id=9828 > > Impact of the bug: Happens

Re: [PATCH update] firewire: fix kobject_add failed for fw* with -EEXIST

2008-01-28 Thread Stefan Richter
Jarod Wilson wrote: Looks straight-forward enough, and I'll give these a spin shortly and see if I can reproduce the situation I was hitting with my raid array... As far as the naming of devices is concerned, the bug and the necessary fix are entirely obvious. But the interaction with

Re: [PATCH update] firewire: fix kobject_add failed for fw* with -EEXIST

2008-01-28 Thread Jarod Wilson
On Sunday 27 January 2008 12:20:40 pm Stefan Richter wrote: There is a race between shutdown and creation of devices: fw-core may attempt to add a device with the same name of an already existing device. http://bugzilla.kernel.org/show_bug.cgi?id=9828 Impact of the bug: Happens rarely,

Re: [PATCH update] firewire: fix kobject_add failed for fw* with -EEXIST

2008-01-28 Thread Jarod Wilson
On Monday 28 January 2008 01:54:14 pm Stefan Richter wrote: Jarod Wilson wrote: We may have another issue there though, as when this happened to me, the md layer apparently never noticed (after ~6 hours) that one of the array members had disappeared -- not sure if that's firewire's fault or

Re: [PATCH update] firewire: fix kobject_add failed for fw* with -EEXIST

2008-01-28 Thread Stefan Richter
I wrote: But the interaction with userspace processes opening /dev/fwX while the respective node is being shut down gave me headaches. I am still not entirely sure if I got it right in the patch update, i.e. if it is free from deadlocks. fw_device_shutdown() and fw_device_op_open() can be

Re: [PATCH update] firewire: fix kobject_add failed for fw* with -EEXIST

2008-01-28 Thread Jarod Wilson
On Sunday 27 January 2008 12:20:40 pm Stefan Richter wrote: There is a race between shutdown and creation of devices: fw-core may attempt to add a device with the same name of an already existing device. http://bugzilla.kernel.org/show_bug.cgi?id=9828 Impact of the bug: Happens rarely,

Re: [PATCH update] firewire: fix kobject_add failed for fw* with -EEXIST

2008-01-28 Thread Stefan Richter
Jarod Wilson wrote: We may have another issue there though, as when this happened to me, the md layer apparently never noticed (after ~6 hours) that one of the array members had disappeared -- not sure if that's firewire's fault or md's though... This will presumably avoid this situation

[PATCH update] firewire: fix "kobject_add failed for fw* with -EEXIST"

2008-01-27 Thread Stefan Richter
There is a race between shutdown and creation of devices: fw-core may attempt to add a device with the same name of an already existing device. http://bugzilla.kernel.org/show_bug.cgi?id=9828 Impact of the bug: Happens rarely, forces the user to unplug and replug the new device to get it

[PATCH update] firewire: fix kobject_add failed for fw* with -EEXIST

2008-01-27 Thread Stefan Richter
There is a race between shutdown and creation of devices: fw-core may attempt to add a device with the same name of an already existing device. http://bugzilla.kernel.org/show_bug.cgi?id=9828 Impact of the bug: Happens rarely, forces the user to unplug and replug the new device to get it