Re: [PATCH uprobe, thp 3/4] uprobe: support huge page by only splitting the pmd

> On May 30, 2019, at 5:14 AM, Kirill A. Shutemov wrote: > > On Wed, May 29, 2019 at 02:20:48PM -0700, Song Liu wrote: >> Instead of splitting the compound page with FOLL_SPLIT, this patch allows >> uprobe to only split pmd for huge pages. >> >> A helper function mm_address_trans_huge(mm,

Re: [PATCH uprobe, thp 3/4] uprobe: support huge page by only splitting the pmd

> On May 30, 2019, at 4:08 AM, William Kucharski > wrote: > > > Is there any reason to worry about supporting PUD-sized uprobe pages if > CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD is defined? I would prefer > not to bake in the assumption that "huge" means PMD-sized and more than > it

Re: [PATCH uprobe, thp 3/4] uprobe: support huge page by only splitting the pmd

On Wed, May 29, 2019 at 02:20:48PM -0700, Song Liu wrote: > Instead of splitting the compound page with FOLL_SPLIT, this patch allows > uprobe to only split pmd for huge pages. > > A helper function mm_address_trans_huge(mm, address) was introduced to > test whether the address in mm is pointing

Re: [PATCH uprobe, thp 3/4] uprobe: support huge page by only splitting the pmd

Is there any reason to worry about supporting PUD-sized uprobe pages if CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD is defined? I would prefer not to bake in the assumption that "huge" means PMD-sized and more than it already is. For example, if CONFIG_HAVE_ARCH_TRANSPARENT_HUGEPAGE_PUD is