Re: [PATCH v1] ARM: imx: avic: Convert to using IRQCHIP_DECLARE

2021-02-01 Thread Martin Kaiser
Thus wrote Saravana Kannan (sarava...@google.com): > On Sun, Jan 31, 2021 at 5:26 PM Fabio Estevam wrote: > > Hi Saravana, > > On Sun, Jan 31, 2021 at 5:56 PM Saravana Kannan > > wrote: > > > +static int __init imx_avic_init(struct device_node *node, > > > +

Re: [PATCH v1] ARM: imx: avic: Convert to using IRQCHIP_DECLARE

2021-01-31 Thread Saravana Kannan
On Sun, Jan 31, 2021 at 5:26 PM Fabio Estevam wrote: > > Hi Saravana, > > On Sun, Jan 31, 2021 at 5:56 PM Saravana Kannan wrote: > > > +static int __init imx_avic_init(struct device_node *node, > > + struct device_node *parent) > > +{ > > + void __iomem

Re: [PATCH v1] ARM: imx: avic: Convert to using IRQCHIP_DECLARE

2021-01-31 Thread Fabio Estevam
Hi Saravana, On Sun, Jan 31, 2021 at 5:56 PM Saravana Kannan wrote: > +static int __init imx_avic_init(struct device_node *node, > + struct device_node *parent) > +{ > + void __iomem *avic_base; > + > + avic_base = of_iomap(node, 0); > +

[PATCH v1] ARM: imx: avic: Convert to using IRQCHIP_DECLARE

2021-01-31 Thread Saravana Kannan
Remove a lot of boilerplate code. Also address boot issues on imx25 with fw_devlink=on that were reported by Martin. Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") Reported-by: Martin Kaiser Signed-off-by: Saravana Kannan --- I've compile tested this for imx25 and imx27. But