Re: [PATCH v1] ARM: keep __my_cpu_offset consistent with generic one

2013-04-04 Thread Ming Lei
Hi, On Thu, Apr 4, 2013 at 12:19 AM, Russell King - ARM Linux wrote: > > Still not convinced this is a proper fix. Look, the problem is this: > > - Initially, set the CPU percpu offset to zero. This means the boot > CPU reads and writes to the percpu data section in the kernel image. > > -

Re: [PATCH v1] ARM: keep __my_cpu_offset consistent with generic one

2013-04-04 Thread Ming Lei
Hi, On Thu, Apr 4, 2013 at 12:19 AM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: Still not convinced this is a proper fix. Look, the problem is this: - Initially, set the CPU percpu offset to zero. This means the boot CPU reads and writes to the percpu data section in the

Re: [PATCH v1] ARM: keep __my_cpu_offset consistent with generic one

2013-04-03 Thread Russell King - ARM Linux
On Tue, Mar 12, 2013 at 10:56:38AM +, Russell King - ARM Linux wrote: > On Tue, Mar 12, 2013 at 10:32:21AM +0800, Ming Lei wrote: > > On Thu, Mar 7, 2013 at 9:35 PM, Ming Lei wrote: > > > Commit 14318efb(ARM: 7587/1: implement optimized percpu variable access) > > > introduces arm's

Re: [PATCH v1] ARM: keep __my_cpu_offset consistent with generic one

2013-04-03 Thread Russell King - ARM Linux
On Tue, Mar 12, 2013 at 10:56:38AM +, Russell King - ARM Linux wrote: On Tue, Mar 12, 2013 at 10:32:21AM +0800, Ming Lei wrote: On Thu, Mar 7, 2013 at 9:35 PM, Ming Lei tom.leim...@gmail.com wrote: Commit 14318efb(ARM: 7587/1: implement optimized percpu variable access) introduces

Re: [PATCH v1] ARM: keep __my_cpu_offset consistent with generic one

2013-03-12 Thread Ming Lei
On Wed, Mar 13, 2013 at 1:25 AM, Tejun Heo wrote: > Hello, > > On Tue, Mar 12, 2013 at 07:44:55PM +0800, Ming Lei wrote: >> On Tue, Mar 12, 2013 at 7:30 PM, Russell King - ARM Linux >> wrote: >> >> >> >> Ingo and Peter, what is your opinion on the problem? >> > >> > Having discussed this with

Re: [PATCH v1] ARM: keep __my_cpu_offset consistent with generic one

2013-03-12 Thread Tejun Heo
Hello, On Tue, Mar 12, 2013 at 07:44:55PM +0800, Ming Lei wrote: > On Tue, Mar 12, 2013 at 7:30 PM, Russell King - ARM Linux > wrote: > >> > >> Ingo and Peter, what is your opinion on the problem? > > > > Having discussed this with Ben Herrenschmidt, it seems that we do need > > to have a more

Re: [PATCH v1] ARM: keep __my_cpu_offset consistent with generic one

2013-03-12 Thread Ming Lei
On Tue, Mar 12, 2013 at 7:30 PM, Russell King - ARM Linux wrote: >> >> Ingo and Peter, what is your opinion on the problem? > > Having discussed this with Ben Herrenschmidt, it seems that we do need > to have a more complex patch to sort this out - we need to setup our > private pointer inside

Re: [PATCH v1] ARM: keep __my_cpu_offset consistent with generic one

2013-03-12 Thread Russell King - ARM Linux
On Tue, Mar 12, 2013 at 07:25:28PM +0800, Ming Lei wrote: > On Tue, Mar 12, 2013 at 6:56 PM, Russell King - ARM Linux > wrote: > >> > >> Looks no one objects the patch, so I has submitted it into Russell's > >> patch system, and hope it can be pushed to linus tree soon and > >> make

Re: [PATCH v1] ARM: keep __my_cpu_offset consistent with generic one

2013-03-12 Thread Ming Lei
On Tue, Mar 12, 2013 at 6:56 PM, Russell King - ARM Linux wrote: >> >> Looks no one objects the patch, so I has submitted it into Russell's >> patch system, and hope it can be pushed to linus tree soon and >> make LOCK_STAT/DEBUG_LOCKDEP usable on ARMv7. > > I'm not convinced it is correct. Is

Re: [PATCH v1] ARM: keep __my_cpu_offset consistent with generic one

2013-03-12 Thread Russell King - ARM Linux
On Tue, Mar 12, 2013 at 10:32:21AM +0800, Ming Lei wrote: > On Thu, Mar 7, 2013 at 9:35 PM, Ming Lei wrote: > > Commit 14318efb(ARM: 7587/1: implement optimized percpu variable access) > > introduces arm's __my_cpu_offset to optimize percpu vaiable access, > > which really works well on

Re: [PATCH v1] ARM: keep __my_cpu_offset consistent with generic one

2013-03-12 Thread Russell King - ARM Linux
On Tue, Mar 12, 2013 at 10:32:21AM +0800, Ming Lei wrote: On Thu, Mar 7, 2013 at 9:35 PM, Ming Lei tom.leim...@gmail.com wrote: Commit 14318efb(ARM: 7587/1: implement optimized percpu variable access) introduces arm's __my_cpu_offset to optimize percpu vaiable access, which really works

Re: [PATCH v1] ARM: keep __my_cpu_offset consistent with generic one

2013-03-12 Thread Ming Lei
On Tue, Mar 12, 2013 at 6:56 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: Looks no one objects the patch, so I has submitted it into Russell's patch system, and hope it can be pushed to linus tree soon and make LOCK_STAT/DEBUG_LOCKDEP usable on ARMv7. I'm not convinced it is

Re: [PATCH v1] ARM: keep __my_cpu_offset consistent with generic one

2013-03-12 Thread Russell King - ARM Linux
On Tue, Mar 12, 2013 at 07:25:28PM +0800, Ming Lei wrote: On Tue, Mar 12, 2013 at 6:56 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: Looks no one objects the patch, so I has submitted it into Russell's patch system, and hope it can be pushed to linus tree soon and make

Re: [PATCH v1] ARM: keep __my_cpu_offset consistent with generic one

2013-03-12 Thread Ming Lei
On Tue, Mar 12, 2013 at 7:30 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: Ingo and Peter, what is your opinion on the problem? Having discussed this with Ben Herrenschmidt, it seems that we do need to have a more complex patch to sort this out - we need to setup our private

Re: [PATCH v1] ARM: keep __my_cpu_offset consistent with generic one

2013-03-12 Thread Tejun Heo
Hello, On Tue, Mar 12, 2013 at 07:44:55PM +0800, Ming Lei wrote: On Tue, Mar 12, 2013 at 7:30 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: Ingo and Peter, what is your opinion on the problem? Having discussed this with Ben Herrenschmidt, it seems that we do need to have

Re: [PATCH v1] ARM: keep __my_cpu_offset consistent with generic one

2013-03-12 Thread Ming Lei
On Wed, Mar 13, 2013 at 1:25 AM, Tejun Heo t...@kernel.org wrote: Hello, On Tue, Mar 12, 2013 at 07:44:55PM +0800, Ming Lei wrote: On Tue, Mar 12, 2013 at 7:30 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: Ingo and Peter, what is your opinion on the problem? Having

Re: [PATCH v1] ARM: keep __my_cpu_offset consistent with generic one

2013-03-11 Thread Ming Lei
On Thu, Mar 7, 2013 at 9:35 PM, Ming Lei wrote: > Commit 14318efb(ARM: 7587/1: implement optimized percpu variable access) > introduces arm's __my_cpu_offset to optimize percpu vaiable access, > which really works well on hackbench, but will cause __my_cpu_offset > to return garbage value before

Re: [PATCH v1] ARM: keep __my_cpu_offset consistent with generic one

2013-03-11 Thread Ming Lei
On Thu, Mar 7, 2013 at 9:35 PM, Ming Lei tom.leim...@gmail.com wrote: Commit 14318efb(ARM: 7587/1: implement optimized percpu variable access) introduces arm's __my_cpu_offset to optimize percpu vaiable access, which really works well on hackbench, but will cause __my_cpu_offset to return

[PATCH v1] ARM: keep __my_cpu_offset consistent with generic one

2013-03-07 Thread Ming Lei
Commit 14318efb(ARM: 7587/1: implement optimized percpu variable access) introduces arm's __my_cpu_offset to optimize percpu vaiable access, which really works well on hackbench, but will cause __my_cpu_offset to return garbage value before it is initialized in cpu_init() called by setup_arch, so

[PATCH v1] ARM: keep __my_cpu_offset consistent with generic one

2013-03-07 Thread Ming Lei
Commit 14318efb(ARM: 7587/1: implement optimized percpu variable access) introduces arm's __my_cpu_offset to optimize percpu vaiable access, which really works well on hackbench, but will cause __my_cpu_offset to return garbage value before it is initialized in cpu_init() called by setup_arch, so