Re: [PATCH v1] PCI: enable ASPM configuration in PCIE POWERSAVE mode

2014-07-13 Thread vidya sagar
m; Stephen >> >>> Warren; Krishna Thota; linux-...@vger.kernel.org; linux- >> >>> ker...@vger.kernel.org; Matthew Garrett; Rafael J. Wysocki >> >>> Subject: Re: [PATCH v1] PCI: enable ASPM configuration in PCIE POWERSAVE >> >>> mode >> &

Re: [PATCH v1] PCI: enable ASPM configuration in PCIE POWERSAVE mode

2014-07-11 Thread Bjorn Helgaas
;> ker...@vger.kernel.org; Matthew Garrett; Rafael J. Wysocki > >>> Subject: Re: [PATCH v1] PCI: enable ASPM configuration in PCIE POWERSAVE > >>> mode > >>> > >>> [+cc Rafael] > >>> > >>> On Sat, Jul 05, 2014 at

Re: [PATCH v1] PCI: enable ASPM configuration in PCIE POWERSAVE mode

2014-07-07 Thread Bjorn Helgaas
gt;> Warren; Krishna Thota; linux-...@vger.kernel.org; linux- >> ker...@vger.kernel.org; Matthew Garrett; Rafael J. Wysocki >> Subject: Re: [PATCH v1] PCI: enable ASPM configuration in PCIE POWERSAVE >> mode >> >> [+cc Rafael] >> >> On Sat, Jul 05, 2014 at 1

RE: [PATCH v1] PCI: enable ASPM configuration in PCIE POWERSAVE mode

2014-07-07 Thread Vidya Sagar
r.kernel.org; Matthew Garrett; Rafael J. Wysocki > Subject: Re: [PATCH v1] PCI: enable ASPM configuration in PCIE POWERSAVE > mode > > [+cc Rafael] > > On Sat, Jul 05, 2014 at 12:57:36PM -0600, Bjorn Helgaas wrote: > > [+cc Matthew] > > > > On Tue, Jul 01,

Re: [PATCH v1] PCI: enable ASPM configuration in PCIE POWERSAVE mode

2014-07-07 Thread Matthew Garrett
On Sat, 2014-07-05 at 13:02 -0600, Bjorn Helgaas wrote: > > Rafael, Matthew, any comments? We have vacillated on this before and > > the web is already pretty tangled. > > > > Vidya, can you give more details about the bug fixed by this change? > > What's the scenario? Are we resuming and the de

Re: [PATCH v1] PCI: enable ASPM configuration in PCIE POWERSAVE mode

2014-07-05 Thread Bjorn Helgaas
[+cc Rafael] On Sat, Jul 05, 2014 at 12:57:36PM -0600, Bjorn Helgaas wrote: > [+cc Matthew] > > On Tue, Jul 01, 2014 at 12:46:18PM +0530, Vidya Sagar wrote: > > commit 1a680b7c moved pcie_aspm_powersave_config_link() out of > > pci_raw_set_power_state() to pci_set_power_state() which would enable

Re: [PATCH v1] PCI: enable ASPM configuration in PCIE POWERSAVE mode

2014-07-05 Thread Bjorn Helgaas
[+cc Matthew] On Tue, Jul 01, 2014 at 12:46:18PM +0530, Vidya Sagar wrote: > commit 1a680b7c moved pcie_aspm_powersave_config_link() out of > pci_raw_set_power_state() to pci_set_power_state() which would enable > ASPM. But, with commit db288c9c, which re-introduced the following check > ./drivers

RE: [PATCH v1] PCI: enable ASPM configuration in PCIE POWERSAVE mode

2014-07-01 Thread Vidya Sagar
er.kernel.org > Cc: linux-kernel@vger.kernel.org > Subject: Re: [PATCH v1] PCI: enable ASPM configuration in PCIE POWERSAVE > mode > > On 07/01/2014 01:16 AM, Vidya Sagar wrote: > > commit 1a680b7c moved pcie_aspm_powersave_config_link() out of > > pci_raw_set_power_state(

Re: [PATCH v1] PCI: enable ASPM configuration in PCIE POWERSAVE mode

2014-07-01 Thread Stephen Warren
On 07/01/2014 01:16 AM, Vidya Sagar wrote: > commit 1a680b7c moved pcie_aspm_powersave_config_link() out of > pci_raw_set_power_state() to pci_set_power_state() which would enable > ASPM. But, with commit db288c9c, which re-introduced the following check > ./drivers/pci/pci.c: pci_set_power_state()

[PATCH v1] PCI: enable ASPM configuration in PCIE POWERSAVE mode

2014-07-01 Thread Vidya Sagar
commit 1a680b7c moved pcie_aspm_powersave_config_link() out of pci_raw_set_power_state() to pci_set_power_state() which would enable ASPM. But, with commit db288c9c, which re-introduced the following check ./drivers/pci/pci.c: pci_set_power_state() + /* Check if we're already there */ + if (dev