[PATCH v1] PM / Domains: Add tracepoints

2019-09-26 Thread Matthias Kaehlcke
Define genpd_power_on/off and genpd_set_performance_state tracepoints and use them. Signed-off-by: Matthias Kaehlcke --- drivers/base/power/domain.c | 27 +--- include/trace/events/power.h | 49 2 files changed, 72 insertions(+), 4 deletions

Re: [PATCH v1] PM / Domains: Add tracepoints

2019-10-01 Thread Matthias Kaehlcke
On Fri, Sep 27, 2019 at 04:42:39AM -0400, Steven Rostedt wrote: > On Thu, 26 Sep 2019 15:04:38 -0700 > Matthias Kaehlcke wrote: > > > Define genpd_power_on/off and genpd_set_performance_state > > tracepoints and use them. > > I agree with Greg about adding a "why" you need this. But, in case > t

Re: [PATCH v1] PM / Domains: Add tracepoints

2019-10-01 Thread Steven Rostedt
On Tue, 1 Oct 2019 09:35:42 -0700 Matthias Kaehlcke wrote: > How about this instead: > > Add tracepoints for genpd_power_on, genpd_power_off and > genpd_set_performance_state. The tracepoints can help with > understanding power domain behavior of a given device, which > may be particular

Re: [PATCH v1] PM / Domains: Add tracepoints

2019-10-01 Thread Matthias Kaehlcke
On Tue, Oct 01, 2019 at 01:03:43PM -0400, Steven Rostedt wrote: > On Tue, 1 Oct 2019 09:35:42 -0700 > Matthias Kaehlcke wrote: > > > How about this instead: > > > > Add tracepoints for genpd_power_on, genpd_power_off and > > genpd_set_performance_state. The tracepoints can help with > > un

Re: [PATCH v1] PM / Domains: Add tracepoints

2019-10-01 Thread Steven Rostedt
On Tue, 1 Oct 2019 10:42:35 -0700 Matthias Kaehlcke wrote: > On Tue, Oct 01, 2019 at 01:03:43PM -0400, Steven Rostedt wrote: > > On Tue, 1 Oct 2019 09:35:42 -0700 > > Matthias Kaehlcke wrote: > > > > > How about this instead: > > > > > > Add tracepoints for genpd_power_on, genpd_power_off

Re: [PATCH v1] PM / Domains: Add tracepoints

2019-10-01 Thread Matthias Kaehlcke
On Tue, Oct 01, 2019 at 02:08:46PM -0400, Steven Rostedt wrote: > On Tue, 1 Oct 2019 10:42:35 -0700 > Matthias Kaehlcke wrote: > > > On Tue, Oct 01, 2019 at 01:03:43PM -0400, Steven Rostedt wrote: > > > On Tue, 1 Oct 2019 09:35:42 -0700 > > > Matthias Kaehlcke wrote: > > > > > > > How about t

Re: [PATCH v1] PM / Domains: Add tracepoints

2019-10-02 Thread Rafael J. Wysocki
On Tue, Oct 1, 2019 at 9:37 PM Matthias Kaehlcke wrote: > > On Tue, Oct 01, 2019 at 02:08:46PM -0400, Steven Rostedt wrote: > > On Tue, 1 Oct 2019 10:42:35 -0700 > > Matthias Kaehlcke wrote: > > > > > On Tue, Oct 01, 2019 at 01:03:43PM -0400, Steven Rostedt wrote: > > > > On Tue, 1 Oct 2019 09:35

Re: [PATCH v1] PM / Domains: Add tracepoints

2019-10-02 Thread Pavel Machek
On Tue 2019-10-01 12:37:01, Matthias Kaehlcke wrote: > On Tue, Oct 01, 2019 at 02:08:46PM -0400, Steven Rostedt wrote: > > On Tue, 1 Oct 2019 10:42:35 -0700 > > Matthias Kaehlcke wrote: > > > > > On Tue, Oct 01, 2019 at 01:03:43PM -0400, Steven Rostedt wrote: > > > > On Tue, 1 Oct 2019 09:35:42 -

Re: [PATCH v1] PM / Domains: Add tracepoints

2019-10-16 Thread Ulf Hansson
On Tue, 15 Oct 2019 at 19:19, Matthias Kaehlcke wrote: > > Hi Ulf, > > On Tue, Oct 15, 2019 at 02:37:42PM +0200, Ulf Hansson wrote: > > On Tue, 1 Oct 2019 at 18:35, Matthias Kaehlcke wrote: > > > > > > On Fri, Sep 27, 2019 at 04:42:39AM -0400, Steven Rostedt wrote: > > > > On Thu, 26 Sep 2019 15:

Re: [PATCH v1] PM / Domains: Add tracepoints

2019-10-16 Thread Matthias Kaehlcke
On Wed, Oct 16, 2019 at 03:47:44PM +0200, Ulf Hansson wrote: > On Tue, 15 Oct 2019 at 19:19, Matthias Kaehlcke wrote: > > > > Hi Ulf, > > > > On Tue, Oct 15, 2019 at 02:37:42PM +0200, Ulf Hansson wrote: > > > On Tue, 1 Oct 2019 at 18:35, Matthias Kaehlcke wrote: > > > > > > > > On Fri, Sep 27, 20

Re: [PATCH v1] PM / Domains: Add tracepoints

2019-09-26 Thread Greg Kroah-Hartman
On Thu, Sep 26, 2019 at 03:04:38PM -0700, Matthias Kaehlcke wrote: > Define genpd_power_on/off and genpd_set_performance_state > tracepoints and use them. This says _what_ you do, but not _why_ you want to do this. Who is going to use this? What can be done with this information that is needed b

Re: [PATCH v1] PM / Domains: Add tracepoints

2019-09-27 Thread Steven Rostedt
On Thu, 26 Sep 2019 15:04:38 -0700 Matthias Kaehlcke wrote: > Define genpd_power_on/off and genpd_set_performance_state > tracepoints and use them. I agree with Greg about adding a "why" you need this. But, in case there's a good reason to have this, I have comments about the code below. > > S

Re: [PATCH v1] PM / Domains: Add tracepoints

2019-10-15 Thread Ulf Hansson
On Tue, 1 Oct 2019 at 18:35, Matthias Kaehlcke wrote: > > On Fri, Sep 27, 2019 at 04:42:39AM -0400, Steven Rostedt wrote: > > On Thu, 26 Sep 2019 15:04:38 -0700 > > Matthias Kaehlcke wrote: > > > > > Define genpd_power_on/off and genpd_set_performance_state > > > tracepoints and use them. > > > >

Re: [PATCH v1] PM / Domains: Add tracepoints

2019-10-15 Thread Matthias Kaehlcke
Hi Ulf, On Tue, Oct 15, 2019 at 02:37:42PM +0200, Ulf Hansson wrote: > On Tue, 1 Oct 2019 at 18:35, Matthias Kaehlcke wrote: > > > > On Fri, Sep 27, 2019 at 04:42:39AM -0400, Steven Rostedt wrote: > > > On Thu, 26 Sep 2019 15:04:38 -0700 > > > Matthias Kaehlcke wrote: > > > > > > > Define genpd_