Re: [PATCH v1] arm64: allow building with kcov coverage on ARM64

On Tue, Apr 12, 2016 at 01:17:00PM +0200, Alexander Potapenko wrote: > On Mon, Apr 4, 2016 at 7:30 PM, Dmitry Vyukov wrote: > > I did not look at all boot crashes and hangs. The low level arch code > > like interrupts and early bootstrap is not interesting in this > > setting,

Re: [PATCH v1] arm64: allow building with kcov coverage on ARM64

On Tue, Apr 12, 2016 at 01:17:00PM +0200, Alexander Potapenko wrote: > On Mon, Apr 4, 2016 at 7:30 PM, Dmitry Vyukov wrote: > > I did not look at all boot crashes and hangs. The low level arch code > > like interrupts and early bootstrap is not interesting in this > > setting, so I just bisected

Re: [PATCH v1] arm64: allow building with kcov coverage on ARM64

Hi James, On Wed, Apr 13, 2016 at 6:12 PM, James Morse wrote: > Hi Alex, > > On 12/04/16 12:17, Alexander Potapenko wrote: >> I also wonder if we can, say, land the change to arch/arm64/Kconfig >> separately from makefile changes that improve the precision or fix >> certain

Re: [PATCH v1] arm64: allow building with kcov coverage on ARM64

Hi James, On Wed, Apr 13, 2016 at 6:12 PM, James Morse wrote: > Hi Alex, > > On 12/04/16 12:17, Alexander Potapenko wrote: >> I also wonder if we can, say, land the change to arch/arm64/Kconfig >> separately from makefile changes that improve the precision or fix >> certain build configurations.

Re: [PATCH v1] arm64: allow building with kcov coverage on ARM64

Hi Alex, On 12/04/16 12:17, Alexander Potapenko wrote: > I also wonder if we can, say, land the change to arch/arm64/Kconfig > separately from makefile changes that improve the precision or fix > certain build configurations. (I'm not sure what you mean by precision) It depends which build

Re: [PATCH v1] arm64: allow building with kcov coverage on ARM64

Hi Alex, On 12/04/16 12:17, Alexander Potapenko wrote: > I also wonder if we can, say, land the change to arch/arm64/Kconfig > separately from makefile changes that improve the precision or fix > certain build configurations. (I'm not sure what you mean by precision) It depends which build

Re: [PATCH v1] arm64: allow building with kcov coverage on ARM64

On Mon, Apr 4, 2016 at 7:30 PM, Dmitry Vyukov wrote: > On Thu, Mar 31, 2016 at 7:18 PM, Alexander Potapenko > wrote: >> On Thu, Mar 31, 2016 at 7:14 PM, Mark Rutland wrote: >>> On Thu, Mar 31, 2016 at 06:33:24PM +0200, Alexander

Re: [PATCH v1] arm64: allow building with kcov coverage on ARM64

On Mon, Apr 4, 2016 at 7:30 PM, Dmitry Vyukov wrote: > On Thu, Mar 31, 2016 at 7:18 PM, Alexander Potapenko > wrote: >> On Thu, Mar 31, 2016 at 7:14 PM, Mark Rutland wrote: >>> On Thu, Mar 31, 2016 at 06:33:24PM +0200, Alexander Potapenko wrote: On Thu, Mar 31, 2016 at 6:00 PM, Mark

Re: [PATCH v1] arm64: allow building with kcov coverage on ARM64

On Thu, Mar 31, 2016 at 7:18 PM, Alexander Potapenko wrote: > On Thu, Mar 31, 2016 at 7:14 PM, Mark Rutland wrote: >> On Thu, Mar 31, 2016 at 06:33:24PM +0200, Alexander Potapenko wrote: >>> On Thu, Mar 31, 2016 at 6:00 PM, Mark Rutland

Re: [PATCH v1] arm64: allow building with kcov coverage on ARM64

On Thu, Mar 31, 2016 at 7:18 PM, Alexander Potapenko wrote: > On Thu, Mar 31, 2016 at 7:14 PM, Mark Rutland wrote: >> On Thu, Mar 31, 2016 at 06:33:24PM +0200, Alexander Potapenko wrote: >>> On Thu, Mar 31, 2016 at 6:00 PM, Mark Rutland wrote: >>> > On Thu, Mar 31, 2016 at 05:09:29PM +0200,

Re: [PATCH v1] arm64: allow building with kcov coverage on ARM64

On Thu, Mar 31, 2016 at 7:14 PM, Mark Rutland wrote: > On Thu, Mar 31, 2016 at 06:33:24PM +0200, Alexander Potapenko wrote: >> On Thu, Mar 31, 2016 at 6:00 PM, Mark Rutland wrote: >> > On Thu, Mar 31, 2016 at 05:09:29PM +0200, Alexander Potapenko

Re: [PATCH v1] arm64: allow building with kcov coverage on ARM64

On Thu, Mar 31, 2016 at 7:14 PM, Mark Rutland wrote: > On Thu, Mar 31, 2016 at 06:33:24PM +0200, Alexander Potapenko wrote: >> On Thu, Mar 31, 2016 at 6:00 PM, Mark Rutland wrote: >> > On Thu, Mar 31, 2016 at 05:09:29PM +0200, Alexander Potapenko wrote: >> >> Currently kcov instrumentation is

Re: [PATCH v1] arm64: allow building with kcov coverage on ARM64

On Thu, Mar 31, 2016 at 06:33:24PM +0200, Alexander Potapenko wrote: > On Thu, Mar 31, 2016 at 6:00 PM, Mark Rutland wrote: > > On Thu, Mar 31, 2016 at 05:09:29PM +0200, Alexander Potapenko wrote: > >> Currently kcov instrumentation is disabled for the following files: > > >

Re: [PATCH v1] arm64: allow building with kcov coverage on ARM64

On Thu, Mar 31, 2016 at 06:33:24PM +0200, Alexander Potapenko wrote: > On Thu, Mar 31, 2016 at 6:00 PM, Mark Rutland wrote: > > On Thu, Mar 31, 2016 at 05:09:29PM +0200, Alexander Potapenko wrote: > >> Currently kcov instrumentation is disabled for the following files: > > > >> arch/x86/boot/* >

Re: [PATCH v1] arm64: allow building with kcov coverage on ARM64

On Thu, Mar 31, 2016 at 6:33 PM, Alexander Potapenko wrote: > On Thu, Mar 31, 2016 at 6:00 PM, Mark Rutland wrote: >> On Thu, Mar 31, 2016 at 05:09:29PM +0200, Alexander Potapenko wrote: >>> On Thu, Mar 31, 2016 at 4:29 PM, Mark Rutland

Re: [PATCH v1] arm64: allow building with kcov coverage on ARM64

On Thu, Mar 31, 2016 at 6:33 PM, Alexander Potapenko wrote: > On Thu, Mar 31, 2016 at 6:00 PM, Mark Rutland wrote: >> On Thu, Mar 31, 2016 at 05:09:29PM +0200, Alexander Potapenko wrote: >>> On Thu, Mar 31, 2016 at 4:29 PM, Mark Rutland wrote: >>> > Hi, >>> > >>> > On Thu, Mar 31, 2016 at

Re: [PATCH v1] arm64: allow building with kcov coverage on ARM64

On Thu, Mar 31, 2016 at 6:00 PM, Mark Rutland wrote: > On Thu, Mar 31, 2016 at 05:09:29PM +0200, Alexander Potapenko wrote: >> On Thu, Mar 31, 2016 at 4:29 PM, Mark Rutland wrote: >> > Hi, >> > >> > On Thu, Mar 31, 2016 at 03:54:45PM +0200, Alexander

Re: [PATCH v1] arm64: allow building with kcov coverage on ARM64

On Thu, Mar 31, 2016 at 6:00 PM, Mark Rutland wrote: > On Thu, Mar 31, 2016 at 05:09:29PM +0200, Alexander Potapenko wrote: >> On Thu, Mar 31, 2016 at 4:29 PM, Mark Rutland wrote: >> > Hi, >> > >> > On Thu, Mar 31, 2016 at 03:54:45PM +0200, Alexander Potapenko wrote: >> >> Add ARCH_HAS_KCOV to

Re: [PATCH v1] arm64: allow building with kcov coverage on ARM64

On Thu, Mar 31, 2016 at 05:09:29PM +0200, Alexander Potapenko wrote: > On Thu, Mar 31, 2016 at 4:29 PM, Mark Rutland wrote: > > Hi, > > > > On Thu, Mar 31, 2016 at 03:54:45PM +0200, Alexander Potapenko wrote: > >> Add ARCH_HAS_KCOV to ARM64 config. Disable instrumentation of

Re: [PATCH v1] arm64: allow building with kcov coverage on ARM64

On Thu, Mar 31, 2016 at 05:09:29PM +0200, Alexander Potapenko wrote: > On Thu, Mar 31, 2016 at 4:29 PM, Mark Rutland wrote: > > Hi, > > > > On Thu, Mar 31, 2016 at 03:54:45PM +0200, Alexander Potapenko wrote: > >> Add ARCH_HAS_KCOV to ARM64 config. Disable instrumentation of > >>

Re: [PATCH v1] arm64: allow building with kcov coverage on ARM64

On Thu, Mar 31, 2016 at 4:29 PM, Mark Rutland wrote: > Hi, > > On Thu, Mar 31, 2016 at 03:54:45PM +0200, Alexander Potapenko wrote: >> Add ARCH_HAS_KCOV to ARM64 config. Disable instrumentation of >> arch/arm64/lib/delay.c > > Why do we disable instrumentation of delay.c?

Re: [PATCH v1] arm64: allow building with kcov coverage on ARM64

On Thu, Mar 31, 2016 at 4:29 PM, Mark Rutland wrote: > Hi, > > On Thu, Mar 31, 2016 at 03:54:45PM +0200, Alexander Potapenko wrote: >> Add ARCH_HAS_KCOV to ARM64 config. Disable instrumentation of >> arch/arm64/lib/delay.c > > Why do we disable instrumentation of delay.c? The main purpose of kcov

Re: [PATCH v1] arm64: allow building with kcov coverage on ARM64

Hi, On Thu, Mar 31, 2016 at 03:54:45PM +0200, Alexander Potapenko wrote: > Add ARCH_HAS_KCOV to ARM64 config. Disable instrumentation of > arch/arm64/lib/delay.c Why do we disable instrumentation of delay.c? What exactly does kcov instrumentation imply? Does it require certain data to be mapped

Re: [PATCH v1] arm64: allow building with kcov coverage on ARM64

Hi, On Thu, Mar 31, 2016 at 03:54:45PM +0200, Alexander Potapenko wrote: > Add ARCH_HAS_KCOV to ARM64 config. Disable instrumentation of > arch/arm64/lib/delay.c Why do we disable instrumentation of delay.c? What exactly does kcov instrumentation imply? Does it require certain data to be mapped

Re: [PATCH v1] arm64: allow building with kcov coverage on ARM64

On Thu, Mar 31, 2016 at 3:54 PM, Alexander Potapenko wrote: > Add ARCH_HAS_KCOV to ARM64 config. Disable instrumentation of > arch/arm64/lib/delay.c > > Signed-off-by: Alexander Potapenko > --- > arch/arm64/Kconfig | 1 + > arch/arm64/lib/Makefile | 3

Re: [PATCH v1] arm64: allow building with kcov coverage on ARM64

On Thu, Mar 31, 2016 at 3:54 PM, Alexander Potapenko wrote: > Add ARCH_HAS_KCOV to ARM64 config. Disable instrumentation of > arch/arm64/lib/delay.c > > Signed-off-by: Alexander Potapenko > --- > arch/arm64/Kconfig | 1 + > arch/arm64/lib/Makefile | 3 +++ > 2 files changed, 4

[PATCH v1] arm64: allow building with kcov coverage on ARM64

Add ARCH_HAS_KCOV to ARM64 config. Disable instrumentation of arch/arm64/lib/delay.c Signed-off-by: Alexander Potapenko --- arch/arm64/Kconfig | 1 + arch/arm64/lib/Makefile | 3 +++ 2 files changed, 4 insertions(+) diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig

[PATCH v1] arm64: allow building with kcov coverage on ARM64

Add ARCH_HAS_KCOV to ARM64 config. Disable instrumentation of arch/arm64/lib/delay.c Signed-off-by: Alexander Potapenko --- arch/arm64/Kconfig | 1 + arch/arm64/lib/Makefile | 3 +++ 2 files changed, 4 insertions(+) diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index