Re: [PATCH v1] auxdisplay: charlcd: Reuse hex_to_bin() instead of custom code

Hi Andy, On Thu, Aug 6, 2020 at 11:56 AM Andy Shevchenko wrote: > > May I ask which version did you have in mind? Now it's merge window for > v5.9-rc1 and patch is still not there... Yeah, apologies, sending it during this merge window... :-) Cheers, Miguel

Re: [PATCH v1] auxdisplay: charlcd: Reuse hex_to_bin() instead of custom code

On Fri, May 29, 2020 at 11:48:53PM +0200, Miguel Ojeda wrote: > Hi Andy, > > On Mon, May 18, 2020 at 9:36 PM Andy Shevchenko > wrote: > > > > hex_to_bin() may be used to convert hexdecimal digit to its binary > > representation. > > > > Signed-off-by: Andy Shevchenko > > --- > > Looks fine to m

Re: [PATCH v1] auxdisplay: charlcd: Reuse hex_to_bin() instead of custom code

Hi Andy, On Mon, May 18, 2020 at 9:36 PM Andy Shevchenko wrote: > > hex_to_bin() may be used to convert hexdecimal digit to its binary > representation. > > Signed-off-by: Andy Shevchenko > --- Looks fine to me and the logic is simpler for the `esc` increase too. Thanks for the cleanup! Were yo

[PATCH v1] auxdisplay: charlcd: Reuse hex_to_bin() instead of custom code

hex_to_bin() may be used to convert hexdecimal digit to its binary representation. Signed-off-by: Andy Shevchenko --- drivers/auxdisplay/charlcd.c | 17 ++--- 1 file changed, 6 insertions(+), 11 deletions(-) diff --git a/drivers/auxdisplay/charlcd.c b/drivers/auxdisplay/charlcd.c in