Re: [PATCH v1] can: mcp251xfd: Add some sysfs debug interfaces for registers r/w

2021-01-23 Thread knigh dark
Vincent MAILHOL 于2021年1月22日周五 下午4:51写道： > > Hi, > > In addition to Marc’s comment, I also have security concerns. > > On Fri. 22 Jan 2021 at 15:22, Su Yanjun wrote: > > When i debug mcp2518fd, some method to track registers is > > needed. This easy debug interface will be ok. > > > > For example,

Re: [PATCH v1] can: mcp251xfd: Add some sysfs debug interfaces for registers r/w

2021-01-22 Thread Vincent MAILHOL
Hi, In addition to Marc’s comment, I also have security concerns. On Fri. 22 Jan 2021 at 15:22, Su Yanjun wrote: > When i debug mcp2518fd, some method to track registers is > needed. This easy debug interface will be ok. > > For example, > read a register at 0xe00: > echo 0xe00 > can_get_reg > c

Re: [PATCH v1] can: mcp251xfd: Add some sysfs debug interfaces for registers r/w

2021-01-22 Thread Su
在 2021/1/22 下午3:22, Marc Kleine-Budde 写道: On 1/22/21 7:22 AM, Su Yanjun wrote: When i debug mcp2518fd, some method to track registers is needed. This easy debug interface will be ok. NACK As the driver uses regmap, everything should be there already. To read use: | cat /sys/kernel/debug/re

Re: [PATCH v1] can: mcp251xfd: Add some sysfs debug interfaces for registers r/w

2021-01-21 Thread Marc Kleine-Budde
On 1/22/21 7:22 AM, Su Yanjun wrote: > When i debug mcp2518fd, some method to track registers is > needed. This easy debug interface will be ok. NACK As the driver uses regmap, everything should be there already. To read use: | cat /sys/kernel/debug/regmap/spi0.0-crc/registers Register write s

[PATCH v1] can: mcp251xfd: Add some sysfs debug interfaces for registers r/w

2021-01-21 Thread Su Yanjun
When i debug mcp2518fd, some method to track registers is needed. This easy debug interface will be ok. For example, read a register at 0xe00: echo 0xe00 > can_get_reg cat can_get_reg write a register at 0xe00: echo 0xe00,0x60 > can_set_reg Signed-off-by: Su Yanjun --- .../net/can/spi/mcp251xf