Re: [PATCH v1] checkpatch: check for #if 0/#if 1

2018-07-25 Thread Joe Perches
On Wed, 2018-07-25 at 16:14 -0700, Prakruthi Deepak Heragu wrote: > The #if 0 or #if 1 is used to toggle features. Warn if #if 0 or #if 1 > is present and suggest that they can be removed. > > Signed-off-by: Abhijeet Dharmapurikar > Signed-off-by: Prakruthi Deepak Heragu > --- > Changes in v1:

Re: [PATCH v1] checkpatch: check for #if 0/#if 1

2018-07-25 Thread Joe Perches
On Wed, 2018-07-25 at 16:14 -0700, Prakruthi Deepak Heragu wrote: > The #if 0 or #if 1 is used to toggle features. Warn if #if 0 or #if 1 > is present and suggest that they can be removed. > > Signed-off-by: Abhijeet Dharmapurikar > Signed-off-by: Prakruthi Deepak Heragu > --- > Changes in v1:

[PATCH v1] checkpatch: check for #if 0/#if 1

2018-07-25 Thread Prakruthi Deepak Heragu
The #if 0 or #if 1 is used to toggle features. Warn if #if 0 or #if 1 is present and suggest that they can be removed. Signed-off-by: Abhijeet Dharmapurikar Signed-off-by: Prakruthi Deepak Heragu --- Changes in v1: - Rephrase the warning message to fit in a single line without 80 column

[PATCH v1] checkpatch: check for #if 0/#if 1

2018-07-25 Thread Prakruthi Deepak Heragu
The #if 0 or #if 1 is used to toggle features. Warn if #if 0 or #if 1 is present and suggest that they can be removed. Signed-off-by: Abhijeet Dharmapurikar Signed-off-by: Prakruthi Deepak Heragu --- Changes in v1: - Rephrase the warning message to fit in a single line without 80 column