Re: [PATCH v1] clk: qcom: Add MSM8916 Global Clock Controller support

2015-02-25 Thread Archit Taneja
Hi Georgi, On 02/24/2015 09:19 PM, Georgi Djakov wrote: On 02/24/2015 06:49 AM, Archit Taneja wrote: Hi, [..] + +static struct freq_tbl ftbl_gcc_mdss_pclk[] = { +{ .src = P_DSI0_PHYPLL_DSI }, +{ } +}; + +static struct clk_rcg2 pclk0_clk_src = { +.cmd_rcgr = 0x4d084, This should

Re: [PATCH v1] clk: qcom: Add MSM8916 Global Clock Controller support

2015-02-25 Thread Archit Taneja
Hi Georgi, On 02/24/2015 09:19 PM, Georgi Djakov wrote: On 02/24/2015 06:49 AM, Archit Taneja wrote: Hi, [..] + +static struct freq_tbl ftbl_gcc_mdss_pclk[] = { +{ .src = P_DSI0_PHYPLL_DSI }, +{ } +}; + +static struct clk_rcg2 pclk0_clk_src = { +.cmd_rcgr = 0x4d084, This should

Re: [PATCH v1] clk: qcom: Add MSM8916 Global Clock Controller support

2015-02-24 Thread Stephen Boyd
On 02/24, Georgi Djakov wrote: > On 02/24/2015 12:46 AM, Stephen Boyd wrote: > > On 02/06/15 10:58, Georgi Djakov wrote: > > > >> + > >> + return qcom_cc_really_probe(pdev, _msm8916_desc, regmap); > >> +} > >> + > >> +static int gcc_msm8916_remove(struct platform_device *pdev) > >> +{ > >> +

Re: [PATCH v1] clk: qcom: Add MSM8916 Global Clock Controller support

2015-02-24 Thread Georgi Djakov
On 02/24/2015 12:46 AM, Stephen Boyd wrote: > On 02/06/15 10:58, Georgi Djakov wrote: >> [...] [..] >> + >> +/* Vote for GPLL0 to turn on */ >> +regmap_read(regmap, 0x45000, ); >> +val |= BIT(0); >> +regmap_write(regmap, 0x45000, val); > > Hm.. I guess this is for the CPU to stay

Re: [PATCH v1] clk: qcom: Add MSM8916 Global Clock Controller support

2015-02-24 Thread Georgi Djakov
On 02/24/2015 06:49 AM, Archit Taneja wrote: > Hi, [..] >> + >> +static struct freq_tbl ftbl_gcc_mdss_pclk[] = { >> +{ .src = P_DSI0_PHYPLL_DSI }, >> +{ } >> +}; >> + >> +static struct clk_rcg2 pclk0_clk_src = { >> +.cmd_rcgr = 0x4d084, > > This should be 0x4d000. Same reason as

Re: [PATCH v1] clk: qcom: Add MSM8916 Global Clock Controller support

2015-02-24 Thread Georgi Djakov
On 02/24/2015 06:49 AM, Archit Taneja wrote: Hi, [..] + +static struct freq_tbl ftbl_gcc_mdss_pclk[] = { +{ .src = P_DSI0_PHYPLL_DSI }, +{ } +}; + +static struct clk_rcg2 pclk0_clk_src = { +.cmd_rcgr = 0x4d084, This should be 0x4d000. Same reason as above. +

Re: [PATCH v1] clk: qcom: Add MSM8916 Global Clock Controller support

2015-02-24 Thread Georgi Djakov
On 02/24/2015 12:46 AM, Stephen Boyd wrote: On 02/06/15 10:58, Georgi Djakov wrote: [...] [..] + +/* Vote for GPLL0 to turn on */ +regmap_read(regmap, 0x45000, val); +val |= BIT(0); +regmap_write(regmap, 0x45000, val); Hm.. I guess this is for the CPU to stay on,

Re: [PATCH v1] clk: qcom: Add MSM8916 Global Clock Controller support

2015-02-24 Thread Stephen Boyd
On 02/24, Georgi Djakov wrote: On 02/24/2015 12:46 AM, Stephen Boyd wrote: On 02/06/15 10:58, Georgi Djakov wrote: + + return qcom_cc_really_probe(pdev, gcc_msm8916_desc, regmap); +} + +static int gcc_msm8916_remove(struct platform_device *pdev) +{ + qcom_cc_remove(pdev); +

Re: [PATCH v1] clk: qcom: Add MSM8916 Global Clock Controller support

2015-02-23 Thread Archit Taneja
Hi, On 02/07/2015 12:28 AM, Georgi Djakov wrote: This is preliminary and not fully tested patch which adds support for the global clock controller found on the MSM8916 based devices. It allows the various device drivers to probe and control their clocks and resets. Signed-off-by: Georgi Djakov

Re: [PATCH v1] clk: qcom: Add MSM8916 Global Clock Controller support

2015-02-23 Thread Stephen Boyd
On 02/06/15 10:58, Georgi Djakov wrote: > [...] > + > +static const struct of_device_id gcc_msm8916_match_table[] = { > + { .compatible = "qcom,gcc-msm8916" }, > + { } > +}; > + > +MODULE_DEVICE_TABLE(of, gcc_msm8916_match_table); Nitpick: Please remove newline between the

Re: [PATCH v1] clk: qcom: Add MSM8916 Global Clock Controller support

2015-02-23 Thread Stephen Boyd
On 02/06/15 10:58, Georgi Djakov wrote: [...] + +static const struct of_device_id gcc_msm8916_match_table[] = { + { .compatible = qcom,gcc-msm8916 }, + { } +}; + +MODULE_DEVICE_TABLE(of, gcc_msm8916_match_table); Nitpick: Please remove newline between the MODULE_DEVICE_TABLE and

Re: [PATCH v1] clk: qcom: Add MSM8916 Global Clock Controller support

2015-02-23 Thread Archit Taneja
Hi, On 02/07/2015 12:28 AM, Georgi Djakov wrote: This is preliminary and not fully tested patch which adds support for the global clock controller found on the MSM8916 based devices. It allows the various device drivers to probe and control their clocks and resets. Signed-off-by: Georgi Djakov

[PATCH v1] clk: qcom: Add MSM8916 Global Clock Controller support

2015-02-06 Thread Georgi Djakov
This is preliminary and not fully tested patch which adds support for the global clock controller found on the MSM8916 based devices. It allows the various device drivers to probe and control their clocks and resets. Signed-off-by: Georgi Djakov --- .../devicetree/bindings/clock/qcom,gcc.txt

[PATCH v1] clk: qcom: Add MSM8916 Global Clock Controller support

2015-02-06 Thread Georgi Djakov
This is preliminary and not fully tested patch which adds support for the global clock controller found on the MSM8916 based devices. It allows the various device drivers to probe and control their clocks and resets. Signed-off-by: Georgi Djakov georgi.dja...@linaro.org ---