Re: [PATCH v1] clk: qcom: lpass: Add CLK_IGNORE_UNUSED for lpass clocks

2019-02-12 Thread Bjorn Andersson
On Thu 20 Dec 03:46 PST 2018, Taniya Das wrote: > The LPASS clocks has a dependency on the GCC lpass clocks to be enabled > before accessing them and that was the reason to mark the gcc lpass clocks > as critical. I have the same problem with the TuringCC in QCS404, that in order to disable the

Re: [PATCH v1] clk: qcom: lpass: Add CLK_IGNORE_UNUSED for lpass clocks

2019-01-22 Thread Taniya Das
Hello Stephen, On 1/19/2019 12:31 AM, Stephen Boyd wrote: Quoting Taniya Das (2019-01-17 03:19:22) On 1/15/2019 3:55 AM, Stephen Boyd wrote: Quoting Taniya Das (2019-01-13 22:12:39) On 1/8/2019 2:34 AM, Stephen Boyd wrote: As far as I know, I'm not suggesting the use of CLK_IS_CRITICAL

Re: [PATCH v1] clk: qcom: lpass: Add CLK_IGNORE_UNUSED for lpass clocks

2019-01-18 Thread Stephen Boyd
Quoting Taniya Das (2019-01-17 03:19:22) > > > On 1/15/2019 3:55 AM, Stephen Boyd wrote: > > Quoting Taniya Das (2019-01-13 22:12:39) > >> > >> > >> On 1/8/2019 2:34 AM, Stephen Boyd wrote: > >>> > >>> As far as I know, I'm not suggesting the use of CLK_IS_CRITICAL here. > >>> But removing

Re: [PATCH v1] clk: qcom: lpass: Add CLK_IGNORE_UNUSED for lpass clocks

2019-01-17 Thread Taniya Das
On 1/15/2019 3:55 AM, Stephen Boyd wrote: Quoting Taniya Das (2019-01-13 22:12:39) On 1/8/2019 2:34 AM, Stephen Boyd wrote: As far as I know, I'm not suggesting the use of CLK_IS_CRITICAL here. But removing CLK_IS_CRITICAL and relying on some random bootloader behavior also looks wrong.

Re: [PATCH v1] clk: qcom: lpass: Add CLK_IGNORE_UNUSED for lpass clocks

2019-01-14 Thread Stephen Boyd
Quoting Taniya Das (2019-01-13 22:12:39) > > > On 1/8/2019 2:34 AM, Stephen Boyd wrote: > > > > As far as I know, I'm not suggesting the use of CLK_IS_CRITICAL here. > > But removing CLK_IS_CRITICAL and relying on some random bootloader > > behavior also looks wrong. Can you clarify what's

Re: [PATCH v1] clk: qcom: lpass: Add CLK_IGNORE_UNUSED for lpass clocks

2019-01-13 Thread Taniya Das
On 1/8/2019 2:34 AM, Stephen Boyd wrote: Quoting Taniya Das (2019-01-06 22:26:00) Hello Stephen, On 12/21/2018 2:34 AM, Stephen Boyd wrote: Quoting Taniya Das (2018-12-20 03:46:25) The LPASS clocks has a dependency on the GCC lpass clocks to be enabled before accessing them and that was

Re: [PATCH v1] clk: qcom: lpass: Add CLK_IGNORE_UNUSED for lpass clocks

2019-01-07 Thread Stephen Boyd
Quoting Taniya Das (2019-01-06 22:26:00) > Hello Stephen, > > On 12/21/2018 2:34 AM, Stephen Boyd wrote: > > Quoting Taniya Das (2018-12-20 03:46:25) > >> The LPASS clocks has a dependency on the GCC lpass clocks to be enabled > >> before accessing them and that was the reason to mark the gcc

Re: [PATCH v1] clk: qcom: lpass: Add CLK_IGNORE_UNUSED for lpass clocks

2019-01-06 Thread Taniya Das
Hello Stephen, On 12/21/2018 2:34 AM, Stephen Boyd wrote: Quoting Taniya Das (2018-12-20 03:46:25) The LPASS clocks has a dependency on the GCC lpass clocks to be enabled before accessing them and that was the reason to mark the gcc lpass clocks as critical. But in the case where the lpass

Re: [PATCH v1] clk: qcom: lpass: Add CLK_IGNORE_UNUSED for lpass clocks

2018-12-20 Thread Stephen Boyd
Quoting Taniya Das (2018-12-20 03:46:25) > The LPASS clocks has a dependency on the GCC lpass clocks to be enabled > before accessing them and that was the reason to mark the gcc lpass clocks > as critical. But in the case where the lpass subsystem would require a > restart, toggling the lpass

[PATCH v1] clk: qcom: lpass: Add CLK_IGNORE_UNUSED for lpass clocks

2018-12-20 Thread Taniya Das
The LPASS clocks has a dependency on the GCC lpass clocks to be enabled before accessing them and that was the reason to mark the gcc lpass clocks as critical. But in the case where the lpass subsystem would require a restart, toggling the lpass reset would from HW clear the SW enable bits of the